Add precs_simplified.jl test #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 77.92% 78.05% +0.13%
==========================================
Files 11 11
Lines 1481 1481
==========================================
+ Hits 1154 1156 +2
+ Misses 327 325 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ChrisRackauckas
approved these changes
Jan 13, 2023
|
This looks good to me. Just needs to be rebased? |
Lightweight version of preconditioners test, using SparseDiffTools to calculate Jacobian without requiring ModelingToolkit.
|
we can probably just remove the other preconditioner test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lightweight version of preconditioners test, functionally identical to precs.jl but using SparseDiffTools to calculate Jacobian directly iinstead of ModelingToolkit.