Use hypot
for BSplineInterpolation
, BSplineApprox
#458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Replaces the equivalent of
sqrt(x^2 + y^2)
withhypot(x, y)
inBSplineInterpolation
andBSplineApprox
ashypot
can be more accurate in some situations and is only marginally slower (~1 ns slower for Float64 arguments). Two tests broke locally due to very minor float changes -- I updated these tests and all now pass locally.The methods that take
u::AbstractArray
have different expressions that look more likesqrt(x^2 + sum(y.^2))
which can't be replaced withhypot
calls so I didn't touch those , e.g.,DataInterpolations.jl/src/interpolation_caches.jl
Lines 905 to 908 in 618ff4b