Skip to content

SCALRCORE-35351 - Agent pools [Runs type only]: Environment Access Provider support #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025

Conversation

soltysss
Copy link
Contributor

Changelog

Documentation

  • I have updated resource/data source documentation in docs

State

  • My changes affect the state
  • I have included a state migration and a unit test for it

}

} else {
options.IsShared = ptr(true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I unshare the agent pool?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty environments = [] attribute

Copy link
Member

@petroprotsakh petroprotsakh Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work, it will fall into this conditional block and pass "is-shared": true in the payload

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, added default value of ["*"] shared agent pool to preserve current behavior.

@ostasyuk ostasyuk merged commit 2e20a58 into master Jul 18, 2025
8 checks passed
@ostasyuk ostasyuk deleted the SCALRCORE-35351 branch July 18, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants