fix: handling for openai NOT_GIVEN default arg value #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alizenhom
approved these changes
Sep 12, 2024
9 tasks
darshit-s3
added a commit
that referenced
this pull request
Sep 12, 2024
* add sentry integration * update readme * hotfix for checking package installed * Support Autogen (#242) * autogen kickstart * enhance autogen * run autogen * finish autogen * add readme * disable cache * Support genai and also add token reporting and other data points (#345) * support genai and also add token reporting * rename example file * fix --------- Co-authored-by: Karthik Kalyanaraman <[email protected]> * fix: weaviate datetime handling for request and response (#346) * fix: weaviate datetime handling for request and response * bump version * bump version --------- Co-authored-by: Karthik Kalyanaraman <[email protected]> * Minor bugfix to langchain instrumentation (#348) * Bugfix * bump version * fix: handling for openai NOT_GIVEN default arg value (#350) * fix: handling for openai NOT_GIVEN default arg value * style: fix formating --------- Co-authored-by: Rohit Kadhe <[email protected]> Co-authored-by: Rohit Kadhe <[email protected]> Co-authored-by: Ali Waleed <[email protected]> Co-authored-by: Karthik Kalyanaraman <[email protected]> Co-authored-by: Karthik Kalyanaraman <[email protected]>
karthikscale3
added a commit
that referenced
this pull request
Sep 16, 2024
* add sentry integration * update readme * hotfix for checking package installed * Support Autogen (#242) * autogen kickstart * enhance autogen * run autogen * finish autogen * add readme * disable cache * Support genai and also add token reporting and other data points (#345) * support genai and also add token reporting * rename example file * fix --------- Co-authored-by: Karthik Kalyanaraman <[email protected]> * fix: weaviate datetime handling for request and response (#346) * fix: weaviate datetime handling for request and response * bump version * bump version --------- Co-authored-by: Karthik Kalyanaraman <[email protected]> * Minor bugfix to langchain instrumentation (#348) * Bugfix * bump version * fix: handling for openai NOT_GIVEN default arg value (#350) * fix: handling for openai NOT_GIVEN default arg value * style: fix formating * fix: tool choice for groq, datetime for cohere (#352) --------- Co-authored-by: Ali Waleed <[email protected]> Co-authored-by: Karthik Kalyanaraman <[email protected]> Co-authored-by: darshit-s3 <[email protected]> Co-authored-by: Karthik Kalyanaraman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New versions of openAI have default arg for many inputs set to
NOT_GIVENwhich breaks the LLMAttributes validation.This PR provides a fix for handling that correctly.
Checklist for adding new integration:
APISin constants folder.SERVICE_PROVIDERSin common.pypatch.pyandinstrumentation.pyfiles.all_instrumentationsin langtrace.py and to theInstrumentationTypein types.py files.