Change how the signalling URL is built #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-name/signalling as the default structure for the signalling websocket. This is due to a change in Scalable Pixel Streaming towards supporting custom frontends on a per application/version basis
david-macpherson
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
The signalling server URL builder needed to be updated to support the new 'custom frontend' feature of SPS.
Solution
Change how the signalling URL is built. We now use host.com/signalling/application-name/ as the default structure for the signalling websocket. This is due to a change in Scalable Pixel Streaming towards supporting custom frontends on a per application/version basis
Documentation
TBD
Test Plan and Compatibility
It works.