Skip to content

Conversation

@dan-tw
Copy link
Contributor

@dan-tw dan-tw commented Mar 21, 2023

Relevant components:

  • GitHub Actions workflow

Problem statement:

Lack of tests running to ensure that our packages can always build

Solution

Introduces a GitHub Actions workflow that will run when a pull request is opened, synched or reopened
This essentially means on create and on every commit made to the PR, this workflow will run and check that the package can continue to build.

Test Plan and Compatibility

Check this pull request for an example

The above demonstrates a commit that has been made to a PR that is causing the test to fail.

…est build of the package on open and synching of pull requests
@dan-tw dan-tw added the enhancement New feature or request label Mar 21, 2023
@dan-tw dan-tw requested a review from david-macpherson March 21, 2023 03:18
@dan-tw dan-tw self-assigned this Mar 21, 2023
@dan-tw dan-tw requested a review from adrianZahra March 21, 2023 03:20
@adrianZahra adrianZahra merged commit c1470ab into ScalablePixelStreaming:v1.0.0 Mar 22, 2023
@dan-tw dan-tw deleted the pull-request-workflow branch March 22, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants