Add semantic tests for extrema algorithms with repeated values #6684

harith-hacky03 · 2025-04-20T04:45:38Z

Proposed Changes

Added semantic tests for extrema algorithms (min_element, max_element, minmax_element) to verify behavior with repeated values
Tests ensure that:
- min_element returns the first occurrence of the minimum value
- max_element returns the first occurrence of the maximum value
- minmax_element returns the first occurrence of the minimum value and the last occurrence of the maximum value
Added tests for all execution policies (seq, par, par_unseq) and custom comparison functions

Any background context you want to provide?

The existing tests for extrema algorithms did not cover the important semantic behavior when dealing with repeated values. These new tests ensure that the algorithms maintain their expected behavior across different execution policies and comparison functions.

Checklist

I have added a new feature and have added tests to go along with it.
I have fixed a bug and have added a regression test.
I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

StellarBot · 2025-04-20T04:50:03Z

Can one of the admins verify this patch?

codacy-production · 2025-04-20T06:36:42Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.07%	✅ 98.65%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`8ffc778`)	196632	167501	85.19%
Head commit (`d7f5933`)	193821 (-2811)	164979 (-2522)	85.12% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6684)	148	146	98.65%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

hkaiser · 2025-04-21T00:15:43Z

libs/core/algorithms/tests/unit/algorithms/max_element.cpp

@@ -7,6 +7,7 @@
 #include <hpx/algorithm.hpp>
 #include <hpx/init.hpp>
 #include <hpx/modules/testing.hpp>
+#include <hpx/parallel/algorithms/max_element.hpp>


Isn't this header file #included implicitly by <hpx/algorithm.hpp>?

hkaiser · 2025-04-21T00:16:34Z

libs/core/algorithms/tests/unit/algorithms/min_element.cpp

@@ -7,6 +7,7 @@
 #include <hpx/algorithm.hpp>
 #include <hpx/init.hpp>
 #include <hpx/modules/testing.hpp>
+#include <hpx/parallel/algorithms/min_element.hpp>


Isn't this header file #included implicitly by <hpx/algorithm.hpp>?

libs/core/algorithms/tests/unit/algorithms/max_element.cpp

libs/core/algorithms/tests/unit/algorithms/min_element.cpp

libs/core/algorithms/tests/unit/algorithms/minmax_element.cpp

hkaiser · 2025-04-21T00:18:10Z

libs/core/algorithms/tests/unit/algorithms/minmax_element.cpp

@@ -7,6 +7,7 @@
 #include <hpx/algorithm.hpp>
 #include <hpx/init.hpp>
 #include <hpx/modules/testing.hpp>
+#include <hpx/parallel/algorithms/minmax_element.hpp>


Isn't this header file #included implicitly by <hpx/algorithm.hpp>?

hkaiser · 2025-04-27T00:51:12Z

@harith-hacky03 please fix the compilation errors reported by the CI, i.e., https://app.circleci.com/pipelines/github/STEllAR-GROUP/hpx/17952/workflows/4f8c9bf6-3bd8-4f14-accb-5fade86d40fa/jobs/404643

harith-hacky03 · 2025-04-27T09:13:16Z

@hkaiser What's the expected behaviour of max_element if i have multiple max elements?

hkaiser · 2025-04-27T14:08:32Z

@hkaiser What's the expected behaviour of max_element if i have multiple max elements?

See: https://en.cppreference.com/w/cpp/algorithm/max_element

Return value
Iterator to the greatest element in the range [first, last). If several elements in the range are equivalent to the greatest element, returns the iterator to the first such element. Returns last if the range is empty.

hkaiser · 2025-04-27T14:10:11Z

@harith-hacky03 please squash your commits and also remove all unrelated changes from this PR.

harith-hacky03 · 2025-04-27T15:02:47Z

@hkaiser Don't know why am i getting those commits

…t, max_element, and minmax_element Signed-off-by: harith-hacky03 <[email protected]>

codacy-production · 2025-04-27T16:47:22Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.65%	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`a31463c`)	243218	208594	85.76%
Head commit (`9755e1a`)	193832 (-49386)	164979 (-43615)	85.11% (-0.65%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6684)	20	20	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

hkaiser · 2025-04-28T14:19:36Z

libs/core/algorithms/include/hpx/parallel/algorithms/minmax.hpp

@@ -771,7 +779,7 @@ namespace hpx::parallel {

                        element_type curr_max_value =
                            HPX_INVOKE(proj, *curr->max);
-                        if (!HPX_INVOKE(f, curr_max_value, max_value))
+                        if (HPX_INVOKE(f, curr_max_value, max_value))


This is now inconsistent with your sequential implementation above (same for the change below). Which version is correct?

hkaiser · 2025-05-09T23:21:52Z

@harith-hacky03 ping?

harith-hacky03 requested a review from hkaiser as a code owner April 20, 2025 04:45

harith-hacky03 force-pushed the feature/extrema-algorithms-semantics branch from 5ab364e to 2b53e19 Compare April 20, 2025 04:47

harith-hacky03 force-pushed the feature/extrema-algorithms-semantics branch from 74b5949 to 9f2fae4 Compare April 20, 2025 08:24

hkaiser added type: enhancement category: tests type: compatibility issue category: algorithms labels Apr 21, 2025

hkaiser reviewed Apr 21, 2025

View reviewed changes

harith-hacky03 force-pushed the feature/extrema-algorithms-semantics branch 2 times, most recently from 20f30ea to b98e3ea Compare April 24, 2025 03:50

harith-hacky03 force-pushed the feature/extrema-algorithms-semantics branch from 3581f34 to a01e4e1 Compare April 27, 2025 03:46

harith-hacky03 force-pushed the feature/extrema-algorithms-semantics branch 2 times, most recently from 2b59d9b to 8cdb1d5 Compare April 27, 2025 14:59

Fix extrema algorithm semantics and add semantic tests for min_elemen…

ac38469

…t, max_element, and minmax_element Signed-off-by: harith-hacky03 <[email protected]>

harith-hacky03 force-pushed the feature/extrema-algorithms-semantics branch from 1800813 to ea79800 Compare April 27, 2025 15:12

Fix extrema algorithm semantics and add semantic tests for min_elemen…

9755e1a

…t, max_element, and minmax_element Signed-off-by: harith-hacky03 <[email protected]>

harith-hacky03 force-pushed the feature/extrema-algorithms-semantics branch from ea79800 to 9755e1a Compare April 27, 2025 15:16

hkaiser reviewed Apr 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add semantic tests for extrema algorithms with repeated values #6684

Add semantic tests for extrema algorithms with repeated values #6684

harith-hacky03 commented Apr 20, 2025

Uh oh!

StellarBot commented Apr 20, 2025

Uh oh!

codacy-production bot commented Apr 20, 2025 •

edited

Loading

Uh oh!

hkaiser Apr 21, 2025

Uh oh!

hkaiser Apr 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hkaiser Apr 21, 2025

Uh oh!

hkaiser commented Apr 27, 2025

Uh oh!

harith-hacky03 commented Apr 27, 2025

Uh oh!

hkaiser commented Apr 27, 2025

Uh oh!

hkaiser commented Apr 27, 2025

Uh oh!

harith-hacky03 commented Apr 27, 2025

Uh oh!

codacy-production bot commented Apr 27, 2025 •

edited

Loading

Uh oh!

hkaiser Apr 28, 2025

Uh oh!

hkaiser commented May 9, 2025

Uh oh!

Uh oh!

Uh oh!

Add semantic tests for extrema algorithms with repeated values #6684

Are you sure you want to change the base?

Add semantic tests for extrema algorithms with repeated values #6684

Conversation

harith-hacky03 commented Apr 20, 2025

Proposed Changes

Any background context you want to provide?

Checklist

Uh oh!

StellarBot commented Apr 20, 2025

Uh oh!

codacy-production bot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkaiser commented Apr 27, 2025

Uh oh!

harith-hacky03 commented Apr 27, 2025

Uh oh!

hkaiser commented Apr 27, 2025

Uh oh!

hkaiser commented Apr 27, 2025

Uh oh!

harith-hacky03 commented Apr 27, 2025

Uh oh!

codacy-production bot commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage summary from Codacy

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hkaiser commented May 9, 2025

Uh oh!

Uh oh!

codacy-production bot commented Apr 20, 2025 •

edited

Loading

codacy-production bot commented Apr 27, 2025 •

edited

Loading