Skip to content

Fix Quick start & Manual Docs #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2021
Merged

Fix Quick start & Manual Docs #5534

merged 3 commits into from
Sep 24, 2021

Conversation

dimitraka
Copy link
Contributor

@dimitraka dimitraka commented Sep 1, 2021 •
edited
Loading

Change Installation instructions in Quick Start Guide and Getting/Building HPX in Manual

[skip ci]

@dimitraka dimitraka requested a review from msimberg as a code owner September 1, 2021 13:31
msimberg
msimberg reviewed Sep 1, 2021
View reviewed changes
@msimberg
Copy link
Contributor

msimberg commented Sep 1, 2021

@dimitraka just FYI, I've added [skip ci] to the PR description since you're not changing any code here. [skip ci] will skip the jenkins builders. Others will still run (and the documentation will still be built).

@hkaiser hkaiser added this to the 1.8.0 milestone Sep 1, 2021
hkaiser
hkaiser previously approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser
Copy link
Member

hkaiser commented Sep 1, 2021

@dimitraka just FYI, I've added [skip ci] to the PR description since you're not changing any code here. [skip ci] will skip the jenkins builders. Others will still run (and the documentation will still be built).

It would be nice if we were able to tie that to the category: documentation label...

@msimberg
Copy link
Contributor

msimberg commented Sep 2, 2021

It would be nice if we were able to tie that to the category: documentation label...

Turns out it's possible. Good idea! I've changed the configuration. Let's see next time if it works...

msimberg
msimberg reviewed Sep 8, 2021
View reviewed changes
msimberg
msimberg reviewed Sep 9, 2021
View reviewed changes
aurianer
aurianer reviewed Sep 13, 2021
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments otherwise LGTM thanks a lot for your work! :)

msimberg
msimberg reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments that I forgot to submit yesterday...

msimberg
msimberg requested changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but did the quickstart and the additions on how to install HPX with various package managers disappear at some point?

@dimitraka dimitraka force-pushed the hpx_quickstart branch 3 times, most recently from e75d526 to 3558f88 Compare September 20, 2021 11:14
msimberg
msimberg previously approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dimitraka! This looks good now.

aurianer
aurianer previously approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@dimitraka dimitraka dismissed stale reviews from aurianer and msimberg via 611feb2 September 21, 2021 17:18
@dimitraka dimitraka force-pushed the hpx_quickstart branch 2 times, most recently from 611feb2 to 08e50ed Compare September 21, 2021 17:41
@msimberg msimberg merged commit 9b596ca into STEllAR-GROUP:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg left review comments

@hkaiser hkaiser hkaiser left review comments

@aurianer aurianer aurianer left review comments

@biddisco biddisco Awaiting requested review from biddisco

Assignees
No one assigned
Labels
category: documentation type: enhancement
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dimitraka @msimberg @hkaiser @aurianer