Skip to content

Rename codegen target to cppgen #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

Conversation

heinezen
Copy link
Member

codegen is now a reserved name in CMake, so we should rename our own codegen target to something else.

This only affects the target name. The invocation and Python code still uses codegen as the name.

@heinezen heinezen added area: buildsystem Related to our cmake/python buildsystem bugfix Restores intended behavior lang: cmake written the CMake buildsystem labels Jun 13, 2025
@heinezen heinezen requested review from Copilot and TheJJ June 13, 2025 22:24
Copilot

This comment was marked as outdated.

Fixes a CMake warning because 'codegen' is a reserved name.
@heinezen heinezen force-pushed the fix/codegen_cmake branch from 5c66e20 to b671dde Compare June 13, 2025 22:28
@TheJJ TheJJ merged commit 865bd54 into SFTtech:master Jun 14, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: buildsystem Related to our cmake/python buildsystem bugfix Restores intended behavior lang: cmake written the CMake buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants