fix(mcp-server): Pass 'layer' and 'ui5Version' to the specification API method exportConfig. #3776
+108
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layer for flex change
🦋 Changeset detectedLatest commit: 499aa40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
use package json instead of vscode dependent check
lint and changelog
815are
changed the title
|
815are
requested review from
Klaus-Keller,
devinea,
heimwege,
johannes-kolbe and
vinayhospete
Klaus-Keller
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
Thanks @815are!
- changes to use
sapuxLayerfor flex changes looks good - changeset exists
- test coverage is great
- did a visual review no manual test
Approved from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported that flex changes are written with wrong value for 'layer' property.
Changes in PR:
exportConfigadjusted to passui5Versionandlayer-> https://github.com/SAP/open-ux-tools/blob/fix/mcpServerFlexChangeLayer/packages/fiori-mcp-server/src/page-editor-api/sapuxFtfsFileIO.ts#L261