feat(store): migrate backend system file from .fioritools to .saptools #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 36433c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
longieirl
reviewed
Oct 22, 2025
packages/odata-service-inquirer/test/unit/prompts/prompts.test.ts
Outdated
Show resolved
Hide resolved
longieirl
reviewed
Oct 22, 2025
packages/store/src/utils/index.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| import { homedir } from 'node:os'; | |||
| import path from 'node:path'; | |||
There was a problem hiding this comment.
Should you be using the named import here? i.e. import { join } from 'node:path';
IainSAP
reviewed
Oct 22, 2025
| import * as systemSelection from '../../src/prompts/datasources/sap-system/system-selection'; | ||
| import LoggerHelper from '../../src/prompts/logger-helper'; | ||
| import { PromptState } from '../../src/utils'; | ||
| import { Service } from '../../../fiori-mcp-server/src/tools/functionalities/page/service'; |
There was a problem hiding this comment.
Not sure this is the correct import ? fiori-mcp-server/ doesnt appear to be used.
Suggested change
| import { Service } from '../../../fiori-mcp-server/src/tools/functionalities/page/service'; |
There was a problem hiding this comment.
Thanks, auto import
devinea
reviewed
Oct 22, 2025
cianmSAP
changed the title
|
lfindlaysap
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal issue 35418
Backend systems are migrated from
.fioritoolsdir to a new.saptoolsfolderUpdates required to
@sap-ux/odata-service-inquirerto not callSystemServicedirectly and utilisegetServiceas a single point of entry. Reducing requirement to check for migration in all crud methods