Skip to content

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

NA

Description

  • removed unused and unnecessary classes
  • deleted the rule that removes the border bottom from the last notification in the notification list/group
  • added margin for every child inside actions, not only for buttons as we can have a popover
  • fixed the RTL rules for the actions

BREAKING CHANGE:

  • removed classes: fd-notification__actions--dismiss, fd-notification--tabs and fd-notification__actions--popover

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • RTL support
  1. The code follows fundamental-styles code standards and style
    NA
  2. Testing
  • Updated tests
  • last commit message should have [ci visual] so it can trigger chromatic visual regression (e.g. test: run chromatic visual regression [ci visual])
  1. Documentation
  • Breaking Changes wiki has been updated in case of breaking changes.

@InnaAtanasova InnaAtanasova added this to the Sprint 61 - Cannes milestone Apr 23, 2021
@InnaAtanasova InnaAtanasova requested a review from a team April 23, 2021 19:30
@InnaAtanasova InnaAtanasova self-assigned this Apr 23, 2021
@netlify
Copy link

netlify bot commented Apr 23, 2021

Deploy preview for fundamental-styles ready!

Built with commit 9546c42

https://deploy-preview-2272--fundamental-styles.netlify.app

@netlify
Copy link

netlify bot commented Apr 23, 2021

Deploy preview for fundamental-styles ready!

Built with commit 7069dae

https://deploy-preview-2272--fundamental-styles.netlify.app

@droshev
Copy link
Contributor

droshev commented May 2, 2021

We are missing show more/less (example).
Screen Shot 2021-05-02 at 11 23 05 AM

Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from missing show less/more example everything is good

@droshev droshev requested review from a team, N1XUS and aberikashvili May 2, 2021 15:36
@InnaAtanasova
Copy link
Contributor Author

apart from missing show less/more example everything is good

It's not in the scope of this PR. I created a separate issue for this: #2325

@InnaAtanasova InnaAtanasova merged commit be6568f into main May 3, 2021
@InnaAtanasova InnaAtanasova deleted the fix/notifications-cleanup branch May 3, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants