Skip to content

chore(core): fix lint errors in notification #7823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2022
Merged

chore(core): fix lint errors in notification #7823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/core/src/lib/notification/notification-service/notification.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class NotificationService {
// Add To array
this.notifications.push({
notificationComponent: notificationComponentRef,
notificationConfig: notificationConfig
notificationConfig
});

const defaultBehaviourOnClose = (): void => {
Expand Down Expand Up @@ -129,7 +129,7 @@ export class NotificationService {
}

/** @hidden attempts to focus previously selected element */
private _restoreFocus() {
private _restoreFocus(): void {
if (typeof this._elementFocusedBeforeNotificationWasOpened?.focus === 'function') {
this._elementFocusedBeforeNotificationWasOpened.focus();
}
Expand Down
4 changes: 2 additions & 2 deletions libs/core/src/lib/notification/notification-utils/notification-group-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export abstract class NotificationGroupBaseDirective implements AfterViewInit, O
constructor(private renderer: Renderer2) {}

/** @hidden */
ngAfterViewInit() {
ngAfterViewInit(): void {
// TODO: update startWith args to be "undefined" after migration to rxjs 7.
// Now it throws irrelevant warning about deprecation
const headersChanges$ = this.notificationHeader.changes.pipe(startWith(0));
Expand Down Expand Up @@ -58,7 +58,7 @@ export abstract class NotificationGroupBaseDirective implements AfterViewInit, O
}

/** @hidden */
ngOnDestroy() {
ngOnDestroy(): void {
this.onDestroy$.next();
}
}