fix(core): menu item should not receive focus on mouse hover and remove extra box shadow [ci visual] #7774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikerodonnell89
added
bug
|
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 01187ed 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/621415b6276b6a0008730d68 😎 Browse the preview: https://deploy-preview-7774--fundamental-ngx.netlify.app |
|
Visit the preview URL for this PR (updated for commit 01187ed): https://fundamental-ngx-gh--pr7774-fix-menu-item-hover-6lqg7122.web.app (expires Thu, 24 Feb 2022 22:53:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
mikerodonnell89
changed the title
mikerodonnell89
changed the title
mikerodonnell89
force-pushed
the
fix/menu-item-hover-focus
branch
from
b32340c to
01187ed
Compare
platon-rov
approved these changes
Feb 24, 2022
droshev
approved these changes
Feb 26, 2022
aberikashvili
pushed a commit
that referenced
this pull request
Mar 7, 2022
author Arkadi Berikashvili <[email protected]> 1645522035 +0400 committer Arkadi Berikashvili <[email protected]> 1646661616 +0400 parent 2c6ab2e author Arkadi Berikashvili <[email protected]> 1645522035 +0400 committer Arkadi Berikashvili <[email protected]> 1646661409 +0400 parent 2c6ab2e author Arkadi Berikashvili <[email protected]> 1645522035 +0400 committer Arkadi Berikashvili <[email protected]> 1646661161 +0400 parent 2c6ab2e author Arkadi Berikashvili <[email protected]> 1645522035 +0400 committer Arkadi Berikashvili <[email protected]> 1646661134 +0400 fix(core): fix carousel issue * fix(core): now time column respects elementsAtOnce config and instead of 7 items now only 5 are shown simultaneously * feat(core): added elementsAtOnce to carousel-column and time component. fixed type issues in wdio * feat(core): updating configs after input change * chore(core): removed redundant properties chore(release): version 0.33.5-rc.8 build 2940 [ci skip] fix(core): fix few issues in multi input (#7760) * fix(core): some issues in multi input of core Fixes #7759 * refactor(core): remove unused code * refactor(core): rename and add comment * fix(core): ctrl+a and delete in custom example test has been failed. was fixed and it do what it's expecting. * fix(core): fix test to passed test some changes applied as expected the behavior. chore(release): version 0.33.5-rc.9 build 2942 [ci skip] docs(core): upload-collection - add range selection to the example (#7761) chore(release): version 0.33.5-rc.10 build 2943 [ci skip] chore(deps): bump core-js from 3.7.0 to 3.21.1 (#7782) Bumps [core-js](https://github.com/zloirock/core-js) from 3.7.0 to 3.21.1. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](zloirock/core-js@v3.7.0...v3.21.1) --- updated-dependencies: - dependency-name: core-js dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix(platform): multi-input - omit extra dataSource triggering (#7788) chore(release): version 0.33.5-rc.11 build 2951 [ci skip] feat(platform): table - range selection & bug fixes (#7768) chore(release): version 0.33.5-rc.12 build 2952 [ci skip] feat(platform): emit event when smart filters have been updated (#7771) chore(release): version 0.33.5-rc.13 build 2953 [ci skip] feat(core): grid-list - range selection using "shift" (#7758) chore(release): version 0.33.5-rc.14 build 2954 [ci skip] fix(platform): upload collections enhancements (#7742) chore(release): version 0.33.5-rc.15 build 2956 [ci skip] fix(core): schematics angular cdk version issue (#7800) chore(release): version 0.33.5-rc.16 build 2968 [ci skip] fix(core): menu item should not receive focus on mouse hover and remove extra box shadow [ci visual] (#7774) * fix(core): menu item should not receive focus on mouse hover * fix(core): remove extra box-shadow on menu [ci visual] chore(release): version 0.33.5-rc.17 build 2979 [ci skip] chore(deps-dev): bump @angular-eslint/eslint-plugin-template (#7806) Bumps [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/angular-eslint/tree/HEAD/packages/eslint-plugin-template) from 13.0.1 to 13.1.0. - [Release notes](https://github.com/angular-eslint/angular-eslint/releases) - [Changelog](https://github.com/angular-eslint/angular-eslint/blob/master/packages/eslint-plugin-template/CHANGELOG.md) - [Commits](https://github.com/angular-eslint/angular-eslint/commits/v13.1.0/packages/eslint-plugin-template) --- updated-dependencies: - dependency-name: "@angular-eslint/eslint-plugin-template" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(release): version 0.33.5-rc.18 build 2980 [ci skip] fix(core): hide dots when there's nothing to scroll fix(core): added disable functions for previous/next buttons in the calendar (#7574) * fix(core): added disable functions for previous/next buttons in the calender * fix(core): changed to input set and added documentation in core * fix(core): added optional date parameter * fix(core): changed the input functions to just booleans for calendar-header, added handling the logic in the calendar, passing date to the disable functions * fix(core): calendar navigation buttons disable functions fixes 1. fixed docs id and source files 2. added better documentation for using disable functions 3. removed unneeded complex layout in the example file 4. removed example from calendar.po.ts 5. removed ariaDisabled as was not neeeded 6. exported disable functions to a separate type 7. checked validation that input functions are actually functions 7. changed function to be called when bindings are changed, active view is changed or selected date is changed 8. added disable functions as inputs for date picker as well 9. added selected date, currently displayed date and active view to be passed as a context to the function 10. fixed some husky errors with unused variables * fix(core): calendar navigation buttons fixes * fix(core): added correct import for navigationbuttondisablefunction type * fix(core): changed working with currentlyDisplayed prop and made documentation more generic * fix(core): added hidden and removed unused and empty function * fix(core): calendar a11y Co-authored-by: Platon Rov <[email protected]> chore(release): version 0.33.5-rc.19 build 2988 [ci skip] Update libs/core/src/lib/carousel/carousel.component.html Co-authored-by: Dmitriy Stepanenko <[email protected]> fix(core): remvoe extra method chore(deps-dev): bump rollup from 2.67.3 to 2.68.0 (#7809) Bumps [rollup](https://github.com/rollup/rollup) from 2.67.3 to 2.68.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.67.3...v2.68.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(release): version 0.33.5-rc.20 build 2993 [ci skip] chore(deps-dev): bump @types/lodash-es from 4.17.5 to 4.17.6 (#7803) Bumps [@types/lodash-es](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash-es) from 4.17.5 to 4.17.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash-es) --- updated-dependencies: - dependency-name: "@types/lodash-es" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(release): version 0.33.5-rc.21 build 2994 [ci skip] chore(deps-dev): bump @wdio/cli from 7.16.15 to 7.16.16 (#7802) Bumps [@wdio/cli](https://github.com/webdriverio/webdriverio) from 7.16.15 to 7.16.16. - [Release notes](https://github.com/webdriverio/webdriverio/releases) - [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md) - [Commits](webdriverio/webdriverio@v7.16.15...v7.16.16) --- updated-dependencies: - dependency-name: "@wdio/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> chore(release): version 0.33.5-rc.22 build 2997 [ci skip] fix(core): layout grid vertical gutter (#7813) chore(release): version 0.33.5-rc.23 build 3002 [ci skip] fix(core): @angular/cdk schematics issue (#7820) chore(release): version 0.33.5-rc.24 build 3013 [ci skip] fix(core): notification a11y (#7330) chore(release): version 0.33.5-rc.25 build 3014 [ci skip] chore(core): fix lint errors in notification (#7823) chore(release): version 0.33.5-rc.26 build 3023 [ci skip] feat(core,platform): bring horizon themes (#7819) chore(release): version 0.33.5-rc.27 build 3026 [ci skip] chore(deps): migrate to the latest nx and angular 13 versions (#7817) * chore(ci): migrate to the latest nx and angular 13 versions * chore(platform): lint fixing * chore(deps): revert to previous version of @angular/cdk due to a bug * test(platform): fix icon tab bar dnd test cases * chore: bump cdk to latest * chore(core,platform): nx migration file removing Co-authored-by: dmitry-stepanenko <[email protected]> Co-authored-by: Platon Rov <[email protected]> chore(release): version 0.33.5-rc.28 build 3045 [ci skip] feat(platform): checkbox,checkbox-group - range selection & code enhancements (#7785) chore(release): version 0.33.5-rc.29 build 3047 [ci skip] fix(core): @angular/cdk schematics issue (#7820) chore(core): fix lint errors in notification (#7823) chore(deps): migrate to the latest nx and angular 13 versions (#7817) * chore(ci): migrate to the latest nx and angular 13 versions * chore(platform): lint fixing * chore(deps): revert to previous version of @angular/cdk due to a bug * test(platform): fix icon tab bar dnd test cases * chore: bump cdk to latest * chore(core,platform): nx migration file removing Co-authored-by: dmitry-stepanenko <[email protected]> Co-authored-by: Platon Rov <[email protected]> feat(platform): checkbox,checkbox-group - range selection & code enhancements (#7785) chore(release): version 0.33.5-rc.29 build 3047 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
part of #9058
Description
Menu item should not receive focus styles on mouse hover. Also remove extra box shadow coming from popover + menu..
Please check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist