fix(core): translations for Notification component #12524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnaAtanasova
force-pushed
the
fix/translate-notifications
branch
from
8a4f4f6 to
61b29b1
Compare
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit d0b8c94): https://fundamental-ngx-gh--pr12524-fix-translate-notifi-fq0k2dhx.web.app (expires Fri, 11 Oct 2024 20:01:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
mikerodonnell89
approved these changes
Oct 8, 2024
mikerodonnell89
requested changes
Oct 8, 2024
There was a problem hiding this comment.
nice work, unit test is just failing on this string (case sensitive) https://github.com/SAP/fundamental-ngx/actions/runs/11223491783/job/31198349523?pr=12524#step:9:9309
InnaAtanasova
force-pushed
the
fix/translate-notifications
branch
from
61b29b1 to
825b868
Compare
mikerodonnell89
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes none,
addresses @mikerodonnell89 comments on Notifications PR #12476 (review)