fix: [ODatav4] Support for property name properties
#886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
added
please merge
| final Object value = cloudSdkValues.remove("properties"); | ||
| if( value instanceof Iterable ) { | ||
| final LinkedList<ProductCount> properties = new LinkedList<ProductCount>(); | ||
| for( Object cloudSdkProperties : ((Iterable<?>) value) ) { |
There was a problem hiding this comment.
Here was the collision before the fix
newtork
reviewed
Aug 12, 2025
...tor/src/main/java/com/sap/cloud/sdk/datamodel/odatav4/generator/NamespaceClassGenerator.java
Outdated
Show resolved
Hide resolved
newtork
approved these changes
Aug 12, 2025
:)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Generating an OData v4 client with a property name
propertieswould create a collision with an internal variable.Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated