chore: bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /dependency-bundles/bom #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-version: 3.18.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
…apache.commons-commons-lang3-3.18.0
…ndency-bundles/bom/org.apache.commons-commons-lang3-3.18.0
newtork
reviewed
Jul 31, 2025
Comment on lines
123
to
125
| methodName = StringUtils.removeStart(methodName, "to"); | ||
| methodName = StringUtils.removeStart(methodName, "_"); | ||
| methodName = removeStartIgnoreCase(methodName, "to"); | ||
| methodName = removeStartIgnoreCase(methodName, "_"); |
There was a problem hiding this comment.
Unfortunately we cannot use the suggested new method, since they have just been introduced with their latest update.
That means any "updated" / non-deprecated API would risk a runtime exceptions for users who still use an older version of commons-lang3 with Cloud SDK 5.21.0
Options have been:
- suppress deprecation warning
use suggest new API(incompatibility risk)- use custom code to replace deprecated API (I chose this option)
newtork
reviewed
Jul 31, 2025
| @@ -58,7 +58,7 @@ public static boolean requiresUserTokenExchange( @Nonnull final DestinationPrope | |||
| requiresUserTokenExchange( @Nonnull final AuthenticationType authType, @Nullable final String systemUser ) | |||
| { | |||
| // Handle special case for SAML Bearer Assertion and SAP Assertion SSO | |||
| if( !StringUtils.isBlank(systemUser) | |||
| if( !StringUtils.isBlankOrEmpty(systemUser) | |||
There was a problem hiding this comment.
(Comment)
| StringUtils | isEmpty | isBlank |
|---|---|---|
null |
true | true |
"" |
true | true |
" " |
false | true |
newtork
reviewed
Jul 31, 2025
...tform/security/src/main/java/com/sap/cloud/sdk/cloudplatform/security/BearerCredentials.java
Outdated
Show resolved
Hide resolved
newtork
approved these changes
Jul 31, 2025
newtork
deleted the
dependabot/maven/dependency-bundles/bom/org.apache.commons-commons-lang3-3.18.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.