generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 20
feat: [OpenAPI] Exclusion of paths and properties #745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
7077014
Test with
a-d 5e50752
Revert changes
a-d 592a389
Add fix
a-d 0076de5
Add test
a-d ed8532a
Format
a-d 5f8c291
Fix PMD
a-d 947ee19
Fix merge
a-d 54fb0b3
Delete datamodel/openapi/openapi-generator/src/test/resources/DataMod…
newtork 9f8eb8a
Update datamodel/openapi/openapi-generator/src/test/java/com/sap/clou…
newtork b9c0813
Merge remote-tracking branch 'origin/main' into float-array-instead-o…
a-d a7dd05f
Merge
a-d 4b51e58
Merge remote-tracking branch 'origin/float-array-instead-of-bigdecima…
a-d 2b502a1
Adapting equals and hashcode generation for float[] (#737)
rpanackal d27fa30
Move out the custom gen feature login
rpanackal 9966ed8
change access to package private
rpanackal fd64019
service loader pattern, visitor like pattern
a-d c6ea658
PoC
a-d 693f5d0
Refine chained strategy pattern
a-d 15919d9
Fix naming; add Javadoc
a-d 83276ee
Fix log level
a-d 9dcd3d4
Merge remote-tracking branch 'origin/main' into openapi/partial-gener…
a-d 2b2ad23
Fix merge; Move files
a-d 1fb0561
Fix PMD, re-order methods
a-d 9118f7e
Minor format improvement
a-d a912116
Fix checkstyle
a-d 231f62b
Fix PMD
a-d 85bdc58
Merge remote-tracking branch 'origin/main' into openapi/partial-gener…
a-d 2cb2e39
Revert refactoring
a-d a72b09d
Fix PMD
a-d d354645
Employ feedback
a-d 4c24133
Fix case of missing schema when attempting to remove property
a-d 3f591b1
Add test case BEFORE
a-d dc7f90c
Update test case AFTER
a-d 791c124
Format
a-d 9124c26
Add comments; Minor code style improvement
a-d 72d8343
Merge remote-tracking branch 'origin/main' into openapi/partial-gener…
a-d 3ecafe3
Null check, minor simplification
a-d 2bf64ff
Add test case BEFORE
a-d f7da471
Add test case AFTER
a-d 68f86d6
Fix assertion
a-d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How could you pass an opportunity for recursion? (the while)
Also the allOf case is not tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recursion is a poisoned fruit. Looks nice on the outside, but makes you sick when problems appear.
I added a test case: 2bf64ff -> f7da471