Skip to content

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Feb 26, 2025

Context

We encountered this in AI SDK, it would be nice to fix. The generated method name is a little embarrassing.

image

Feature scope:

  • Feature toggle (default: disabled)
  • Drop the double "is"-prefix.
    • There may be side effects though.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@newtork newtork added the please review Request to review a pull request label Feb 26, 2025
Copy link
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@newtork newtork merged commit 637ea1a into main Feb 27, 2025
14 checks passed
@newtork newtork deleted the openapi/fix-isisboolean branch February 27, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review Request to review a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants