feat: [OpenAPI] Add toMap() and deprecate getCustomField(String)
#723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
changed the title
getAllFields() and deprecate getCustomField(String)toMap() and deprecate getCustomField(String)
7 tasks
newtork
reviewed
Feb 20, 2025
| public Map<String, Object> toMap() | ||
| { | ||
| final Map<String, Object> declaredFields = new LinkedHashMap<>(cloudSdkCustomFields); | ||
| {{#vars}}if( {{name}} != null ) declaredFields.put("{{name}}", {{name}}); |
There was a problem hiding this comment.
We could've used getter instead of direct field access. But I think it's fine (for now)
newtork
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Support allFields in OpenAPI generator #165
When the model classes are re-generated and receive additional fields,
getCustomField(String)can now throwNoSuchElementExceptioninstead of returning a value, making it a breaking change upon re-generating.toMap()would returns the same map every time, no matter the spec and generated model class.Corresponding AI SDK PR
Definition of Done
Documentation updated