Skip to content

Conversation

MatKuhr
Copy link
Member

@MatKuhr MatKuhr commented Jan 15, 2025

Context

Fixes a compilation issue in case enum is used together with a discriminator.

Background: This is a frequent use case, as people want to explicitly limit the allowed values for the discriminator. In OpenAPI 3.0, this is done by declaring an enum with just one value.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Documentation updated
  • Release notes updated

@MatKuhr MatKuhr requested a review from newtork January 15, 2025 16:32
@MatKuhr MatKuhr added please review Request to review a pull request please merge Request to merge a pull request labels Jan 20, 2025
newtork
newtork previously approved these changes Jan 23, 2025
Copy link
Contributor

@newtork newtork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a breaking change, but since it's behind a feature toggle, presumably that's acceptable.

@MatKuhr MatKuhr requested a review from newtork January 23, 2025 12:36
@MatKuhr MatKuhr enabled auto-merge (squash) January 23, 2025 12:36
@MatKuhr MatKuhr merged commit 25e10d8 into main Jan 24, 2025
14 checks passed
@MatKuhr MatKuhr deleted the fix/openapi-discriminator-enum branch January 24, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please merge Request to merge a pull request please review Request to review a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants