Exchange HashMap with LinkedHashMap (odata v2) #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
approved these changes
Dec 18, 2024
| @@ -356,7 +356,7 @@ protected Map<String, Object> toMapOfFields() | |||
| @Override | |||
| protected void fromMap( final Map<String, Object> inputValues ) | |||
| { | |||
| final Map<String, Object> cloudSdkValues = Maps.newHashMap(inputValues); | |||
| final Map<String, Object> cloudSdkValues = Maps.newLinkedHashMap(inputValues); | |||
There was a problem hiding this comment.
(minor) technically, changing the fromMap implementation should have no influence for the ordering of keys. Still, it doesn't hurt to use a linked map here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#DRAFT.
A user reported that there can be instances where a change in the order of complex keys causes issues (see GH issue). To circumvent that, this PR changes the use of
HashMapintoLinkedHashMapin the code generator for odata v2.Feature scope:
LinkedHashMapinstead ofHashMapDefinition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated