Fix: TLS Upgrade config propagates to RestTemplate #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesDuboisSAP
added
please merge
MatKuhr
reviewed
Dec 10, 2024
.../main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultApacheHttpClient5Factory.java
Outdated
Show resolved
Hide resolved
MatKuhr
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
LGTM
We could consider to apply the same change to the v4 Apache client. However, RestTemplate requires the v5 Apache client now, so we don't have the same test case. So we would have to find something else to test or just leave it untested. So maybe we just leave it as-is until we see a use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#659
Feature scope:
Definition of Done
Documentation updated