fix: Destination Service Error Handling #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
added
please merge
MatKuhr
commented
Aug 22, 2024
| Try<String> maybeBody = Try.of(() -> HttpEntityUtil.getResponseBody(response)); | ||
| String logMessage = "Destination service returned HTTP status %s (%s)"; | ||
| if( maybeBody.isFailure() ) { | ||
| final var ex = |
There was a problem hiding this comment.
(used var for better formatting)
...rc/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationServiceAdapterTest.java
Outdated
Show resolved
Hide resolved
…AP/cloud-sdk-java into fix/destination-service-error-handling
newtork
reviewed
Aug 26, 2024
| requestUri)); | ||
| } | ||
| Try<String> maybeBody = Try.of(() -> HttpEntityUtil.getResponseBody(response)); | ||
| String logMessage = "Destination service returned HTTP status %s (%s)"; |
There was a problem hiding this comment.
(Comment)
I'm not a fan of the dynamic string construction for log- and exception-messages. I know the format string %s is different from the log string template {} but I'm not sure the solution is the "best" practice yet.
The dynamic construction makes the code below complicated and during troubleshooting, we have to think twice, how a messages maps a corresponding piece of code.
There was a problem hiding this comment.
Same, I felt this was a tradeoff between complex code vs. code duplication. Maybe at some point we switch to a more high-level HTTP client, where we don't have to re-implement this response handling every time 😄
newtork
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This fixes a bug that would cause HTTP connections to stay open in case the destination service returns an error with payload. Which is the case for e.g. 404 responses.
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated