fix: OData Batch Error Handling #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
added
please merge
MatKuhr
commented
Aug 15, 2024
...ient/src/main/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataRequestGeneric.java
Outdated
Show resolved
Hide resolved
CharlesDuboisSAP
previously requested changes
Aug 16, 2024
...ain/java/com/sap/cloud/sdk/datamodel/odata/client/request/ODataHealthyResponseValidator.java
Outdated
Show resolved
Hide resolved
...ap/cloud/sdk/datamodel/odatav4/referenceservice/ODataClientBatchResponseParsingUnitTest.java
Show resolved
Hide resolved
newtork
reviewed
Aug 19, 2024
Co-authored-by: Alexander Dümont <[email protected]>
newtork
reviewed
Aug 19, 2024
| * @throws ODataResponseException | ||
| * When the response code infers an unhealthy state, i.e. when >= 400. | ||
| * @throws ODataServiceErrorException | ||
| * When the response contains an OData error message according to specification. | ||
| */ | ||
| static void requireHealthyResponse( @Nonnull final ODataRequestResult result ) | ||
| { | ||
| final ODataRequestGeneric request = result.getODataRequest(); | ||
| ODataRequestGeneric request = result.getODataRequest(); |
There was a problem hiding this comment.
(Comment)
I would prefer if this variable was called origin or originRequest, hoping next time I will understand getODataRequest() and getHttpResponse() are not directly connected! 🙈
newtork
previously approved these changes
Aug 19, 2024
newtork
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix for #542
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated