[OpenAPI Generator] When deleting files, only consider specific packages #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
added
please merge
MatKuhr
reviewed
Aug 9, 2024
...enerator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/DataModelGenerator.java
Outdated
Show resolved
Hide resolved
newtork
changed the title
MatKuhr
reviewed
Aug 9, 2024
...enerator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/DataModelGenerator.java
Outdated
Show resolved
Hide resolved
...enerator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/DataModelGenerator.java
Outdated
Show resolved
Hide resolved
MatKuhr
previously approved these changes
Aug 9, 2024
…Path by replacing `.` with `${File.separator}`; Reduce code duplicate; Add input validation to package names
MatKuhr
reviewed
Aug 9, 2024
...enerator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/DataModelGenerator.java
Outdated
Show resolved
Hide resolved
MatKuhr
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be good if we checked for any unexpected files before blindly deleting user-provided paths.To stay safe, we should only delete what was being generated, according to the configuration provided.
* Also I want us to retain "hidden" files (with
.-prefix), to keep custom files like.gitignoreor.openapi-generator-ignore)