feat(ml-dsa): Implement verifying_key method for SigningKey #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to add an impl of the You can keep the inherent method too so it still works with the trait out-of-scope |
Introduce a utility method to derive a VerifyingKey from a SigningKey, even when the original seed or precomputed public key is unavailable. This aids in scenarios where private keys are imported from external sources lacking associated public key data. References: - https://github.com/RustCrypto/signatures/blob/6cc40e5c10b04dae44d91500d5a1afc4a3ff2b49/ml-dsa/src/lib.rs#L856 Co-authored-by: Nicola Tuveri <[email protected]> Signed-off-by: Francesco Rollo <[email protected]> Change-Id: I6a6a6964ee2d466e43dc65bf07cfb6d5b4bfa6c4
…_key() method Implement the `signature::Keypair` trait for `SigningKey`, enabling derivation of a `VerifyingKey` from a bare signing key. Refactor the inherent `verifying_key` method to act as a convenience shim around the trait implementation, ensuring a single source of logic and improving interoperability.
romen
force-pushed
the
nt/mldsa_derive_public
branch
from
2fa345d to
d57bfe0
Compare
|
@tarcieri sorry, it took some time. I rebased this PR on latest master, and added the trait implementation. The inherent method is now just a convenience shim around calling the trait implementation. |
tarcieri
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a utility method to derive a
VerifyingKeyfrom aSigningKey, even when the original seed or precomputed public key is unavailable. This aids in scenarios where private keys are imported from external sources lacking associated public key data.