Skip to content

Conversation

@thingineeer
Copy link
Collaborator

@thingineeer thingineeer commented Mar 5, 2024

🌱 작업한 내용

  • 클로저 변수를, 클로저 파라미터($0)로 수정하였습니다.
  • 중복되는 레이아웃 제거하였습니다.
  • 라이브러리 사용하는 곳은 import 해서 해주었습니다. ex) SnapKit

🌱 PR Point

  • SnapKit 레이아웃 부분을 클로저 파라미터($0)로 변경

📮 관련 이슈

Copy link
Collaborator

@513sojin 513sojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 ~ 꼼꼼하게 보느라 수고 많으셨어용

Comment on lines -482 to -484
profileNameLabel.snp.makeConstraints {
$0.leading.equalTo(profileImageView.snp.trailing).offset(12)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 필요없어져서 주석 처리한건가요 ~?

Copy link
Collaborator Author

@thingineeer thingineeer Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


// MARK: - CourseListCVCDelegate

extension MarathonMapCollectionViewCell: CourseListCVCDeleagte {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭐가 문제인지 한참 봤네요 ,, 굿굿 ~~~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋㅋㅋㅋㅋㅋㅋ 오타가 눈에 너무 보였어요..

@thingineeer thingineeer merged commit ff17e8b into Runnect:develop Mar 6, 2024
@thingineeer thingineeer deleted the #257---내가-그린-코스-순환-참조-문제 branch March 6, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] #257 - 전체 레이아웃 코드 정리

2 participants