[Refactor] #113 - CourseDiscoveryVC에 연결된 라우터들 PublicCouseRouter로 통합 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-yeonwoo
requested review from
dlwogus0128 and
lsj8706
and removed request for
lsj8706
lsj8706
approved these changes
Feb 21, 2023
Collaborator
lsj8706
left a comment
lsj8706
left a comment
There was a problem hiding this comment.
수고하셨습니다~~!!!👍👍
자잘한 수정들만 해서 바로 머지 해주세요!
| case .courseUploadingData(param: let param): | ||
| do { | ||
| return .requestParameters(parameters: try param.asParameter(), encoding: JSONEncoding.default) | ||
|
|
| ) | ||
|
|
||
| private let courseDetailProvider = MoyaProvider<UploadedCourseDetailRouter>( | ||
| private let courseDetailProvider = MoyaProvider<PublicCourseRouter>( |
Collaborator
There was a problem hiding this comment.
Suggested change
| private let courseDetailProvider = MoyaProvider<PublicCourseRouter>( | |
| private let publicCourseProvider = MoyaProvider<PublicCourseRouter>( |
Provider 이름을 이렇게 수정해주세요~! 다른 Provider 들도 똑같이 이 이름으로 통일합시당!
Comment on lines
61
to
65
| switch self { | ||
| case .getCourseData, .courseUploadingData, .getUploadedCourseInfo, .getUploadedCourseDetail, .getCourseSearchData: | ||
| return Config.headerWithDeviceId | ||
|
|
||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| switch self { | |
| case .getCourseData, .courseUploadingData, .getUploadedCourseInfo, .getUploadedCourseDetail, .getCourseSearchData: | |
| return Config.headerWithDeviceId | |
| } | |
| switch self { | |
| default: | |
| return Config.headerWithDeviceId | |
| } |
switch 문에서 모든 case가 같은 결과를 필요로 한다면 이렇게 default로 한번에 처리 할 수 있습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 작업한 내용
🌱 PR Point
📸 스크린샷
없음
📮 관련 이슈