Skip to content

Conversation

Tonyyang0606
Copy link
Contributor

Feature Description

Current timer UI for reference
057aa2de67f544849d9c5ebef16f414
f484651c396a7d96ede4f5b11bf3c99

New Functionality

  • Adds support for real-time duration adjustments during an active session.
  • Tapping Time Adjustment will reveal options like:
    • Increase 5 min
    • Decrease 5 min
    • Increase 1 min
    • Decrease 1 min
    • etc.
  • Adjustments only apply to the current session , not future ones.

Compatibility

✔️ Works with these modes:

  • normal timing / simple countdown

Notes

  • UI/UX follows the existing timer design pattern.
  • No impact on saved presets or future sessions.

Copy link

@RoderickQiu
Copy link
Owner

RoderickQiu commented Apr 16, 2025

Thanks for your contribution!

After investigating about the code, I want to point out two things:

  • If it doesn't work for positive timing mode, then I suggest that it should be hidden in that mode (methodFromStart===3 means positive timing in timer.html).
  • I suggest that the comments in the code should use English, instead of Chinese.

After the two things are achieved, I will be glad to merge this PR!

P.S. Never mind about the failing checks, I believe they are malfunctioning as for now.

@Tonyyang0606
Copy link
Contributor Author

Thanks for the review!
I’ve addressed both issues:

  1. The feature is now hidden when methodFromStart === 3 (i.e., in positive timing mode).
  2. All comments have been translated into English.
    Please let me know if there's anything else to improve. Looking forward to the merge!

@RoderickQiu RoderickQiu self-requested a review April 16, 2025 16:54
Copy link
Owner

@RoderickQiu RoderickQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@RoderickQiu RoderickQiu merged commit 0494de4 into RoderickQiu:master Apr 16, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants