Fix incorrect user count in getUsersOfRoom (includes deactivated users)

[Alok-2005]

While reviewing apps/meteor/server/methods/getUsersOfRoom.ts, I noticed an existing TODO indicating that deactivated users are currently being included in the total user count:

The current implementation counts subscriptions based on the existence of a username, which also includes users that have been deactivated. This results in the total value including users who should no longer be considered active members of the room.

Proposed direction (seeking confirmation before implementation):

• Update the total calculation to exclude deactivated users, in line with the existing TODO
• Ensure deactivated users are excluded from the count
• Keep total and records.length consistent

I’d be happy to work on this fix and submit a PR once the preferred approach is confirmed.

[Alok-2005]

@adrianYT028
I’d like to clarify something here. I had already raised this issue and was actively working on it, and I was waiting for confirmation from the mentors before proceeding further.

As per the project guidelines, contributors are expected to discuss an issue and receive confirmation before raising a PR. However, a PR was raised for the same issue without any prior discussion or coordination with me.

This impacts ongoing work and leads to duplicate efforts. In the future, please ensure that communication happens on the issue thread and that the contribution guidelines are followed, as this reflects professionalism.

I request the mentors to please review this and advise on how to proceed.

[adrianYT028]

hey i am sorry i didnt know that was a rule can you tell me what i should do?

…

On Wed, Dec 31, 2025 at 9:25 AM Alok007 ***@***.***> wrote: *Alok-2005* left a comment (RocketChat/Rocket.Chat#38014) <#38014 (comment)> @adrianYT028 <https://github.com/adrianYT028> I’d like to clarify something here. I had already raised this issue and was actively working on it, and I was waiting for confirmation from the mentors before proceeding further. As per the project guidelines, contributors are expected to discuss an issue and receive confirmation before raising a PR. However, a PR was raised for the same issue without any prior discussion or coordination with me. This impacts ongoing work and leads to duplicate efforts. In the future, please ensure that communication happens on the issue thread and that the contribution guidelines are followed, as this reflects professionalism. I request the mentors to please review this and advise on how to proceed. — Reply to this email directly, view it on GitHub <#38014 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBL364XOQMR3Z7CFJJPOULT4ENCMDAVCNFSM6AAAAACQKDP22OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMBRGM4DQNRRHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>