Skip to content

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Oct 14, 2025

Proposed changes

Enforces the usage of import type or import { type.
There's no performance gains, but it better shows code intent, helps AI, etc.

Note for reviewer: this is all generated automatically through npx eslint . --fix, so no need to review file by file.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1061

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

193 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore.import-type

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@diegolmello diegolmello marked this pull request as ready for review October 14, 2025 17:06
@diegolmello diegolmello temporarily deployed to approve_e2e_testing October 15, 2025 14:29 — with GitHub Actions Inactive
@diegolmello diegolmello requested a deployment to official_android_build October 15, 2025 14:34 — with GitHub Actions Waiting
@diegolmello diegolmello deployed to experimental_android_build October 15, 2025 14:34 — with GitHub Actions Active
@diegolmello diegolmello temporarily deployed to experimental_ios_build October 15, 2025 14:34 — with GitHub Actions Inactive
@diegolmello diegolmello requested a deployment to upload_experimental_android October 15, 2025 15:15 — with GitHub Actions Waiting
Copy link

Android Build Available

Rocket.Chat Experimental 4.66.0.107572

Internal App Sharing: https://play.google.com/apps/test/RQVpXLytHNc/ahAO29uNTlpjoqa5qw8i41lEKoGPf3hC3c5C6p8cjsqAVjNDb13w-SKMqonSP14r-uZTx0cAdrBNeV3MBH6MkwtSk-

Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@diegolmello diegolmello merged commit aa1a61a into develop Oct 15, 2025
26 of 31 checks passed
@diegolmello diegolmello deleted the chore.import-type branch October 15, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants