Support getting logger name for subscription, publisher, service and client #1224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for getting the logger name for ROS 2 entities (subscription, publisher, service, and client) by exposing a loggerName getter property on each entity class.
- Adds
loggerNamegetter property to Publisher, Subscription, Service, and Client classes - Stores node references in Publisher and Subscription constructors to enable logger name access
- Adds comprehensive test coverage for the new
loggerNameproperty across all entity types
Reviewed Changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/publisher.js | Adds node reference storage and loggerName getter using rclnodejs.getNodeLoggerName() |
| lib/subscription.js | Adds node reference storage and loggerName getter using rclnodejs.getNodeLoggerName() |
| lib/service.js | Adds loggerName getter using existing _nodeHandle property |
| lib/client.js | Adds loggerName getter using existing _nodeHandle property |
| test/test-publisher.js | Adds test verifying loggerName returns a string for publishers |
| test/test-subscription.js | Adds test verifying loggerName returns a string for subscriptions |
| test/test-service.js | Adds test verifying loggerName returns a string for both services and clients |
| test/types/index.test-d.ts | Adds TypeScript type assertions for loggerName property on all entity types |
| result.sum = request.a + request.b; | ||
| } | ||
| ); | ||
| const client = node.createClient(AddTwoInts, 'single_ps_channel2'); |
There was a problem hiding this comment.
The variable AddTwoInts is not defined in this scope. It should be defined as a string like 'example_interfaces/srv/AddTwoInts' to match the service type used above.
Suggested change
| const client = node.createClient(AddTwoInts, 'single_ps_channel2'); | |
| const client = node.createClient('example_interfaces/srv/AddTwoInts', 'single_ps_channel2'); |
Copilot uses AI. Check for mistakes.
minggangw
added a commit
that referenced
this pull request
Aug 18, 2025
…client (#1224) This pull request adds support for getting the logger name for ROS 2 entities (subscription, publisher, service, and client) by exposing a `loggerName` getter property on each entity class. - Adds `loggerName` getter property to Publisher, Subscription, Service, and Client classes - Stores node references in Publisher and Subscription constructors to enable logger name access - Adds comprehensive test coverage for the new `loggerName` property across all entity types Fix: #1219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for getting the logger name for ROS 2 entities (subscription, publisher, service, and client) by exposing a
loggerNamegetter property on each entity class.loggerNamegetter property to Publisher, Subscription, Service, and Client classesloggerNameproperty across all entity typesFix: #1219