Fix test-type-description-service.js flakiness #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggangw
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses test flakiness in the type description service tests by refining the asynchronous wait logic and cleaning up unused imports. Key changes include:
- Removal of the unused assertUtils import.
- Transition from a promise chain to async/await for waiting on the service and handling the response.
- Introduction of an interval-based polling mechanism to send the request and clear the timer upon response.
Comments suppressed due to low confidence (1)
test/test-type-description-service.js:65
- Consider adding a comment to explain the rationale for reducing the waitForService timeout from 60 seconds to 5 seconds, to aid future maintainability.
const result = await client.waitForService(5000);
| resolve(); | ||
| }); | ||
| }); | ||
| }, 2000); |
There was a problem hiding this comment.
Consider extracting the polling interval (2000ms) into a constant to enhance clarity and simplify future adjustments.
Suggested change
| }, 2000); | |
| }, POLLING_INTERVAL_MS); |
Copilot uses AI. Check for mistakes.
minggangw
added a commit
that referenced
this pull request
Jun 18, 2025
This PR addresses test flakiness in the type description service tests by refining the asynchronous wait logic and cleaning up unused imports. Key changes include: - Removal of the unused assertUtils import. - Transition from a promise chain to async/await for waiting on the service and handling the response. - Introduction of an interval-based polling mechanism to send the request and clear the timer upon response. Fix: #1154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses test flakiness in the type description service tests by refining the asynchronous wait logic and cleaning up unused imports. Key changes include:
Fix: #1154