Only run workflow on develop branch for arm64 arch #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures ARM64 build jobs only run on the develop branch and extends branch checks to pull request contexts.
- Added a
matrix-prepjob that outputs an ARM64 matrix only when targetingdevelop. - Updated the build job to depend on
matrix-prepand dynamically include ARM64 config. - Enhanced ROS distro detection to consider both
github.refandgithub.base_reffor branch-based flags.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/linux-build-and-test.yml | Introduced matrix-prep job and wired dynamic ARM64 matrix into the build strategy. |
| .github/workflows/identify-ros-distro.yml | Adjusted environment variables to check both github.ref and github.base_ref for branches. |
Comments suppressed due to low confidence (1)
.github/workflows/linux-build-and-test.yml:41
- Using
runs-on: ubuntu-${{ matrix.ubuntu-version }}may resolve to invalid runner labels likeubuntu-24.04-arm, which are not supported by GitHub-hosted runners. Consider using a valid runner label (e.g.,ubuntu-latest) and configuring architecture separately or setting up a self-hosted runner.
runs-on: ubuntu-${{ matrix.ubuntu-version }}
| steps: | ||
| - id: set-matrix | ||
| run: | | ||
| if [[ ${{ contains(github.base_ref, 'develop') || contains(github.ref, 'develop') }} ]]; then |
There was a problem hiding this comment.
The bash conditional [[ ${{ ... }} ]] always succeeds since both 'true' and 'false' are non-empty strings. Compare the expression explicitly to 'true' (e.g., if [ "${{ contains(...) }}" = 'true' ]; then) or use if ${{ contains(...) }}; then to make the branch logic correct.
Suggested change
| if [[ ${{ contains(github.base_ref, 'develop') || contains(github.ref, 'develop') }} ]]; then | |
| if [ "${{ contains(github.base_ref, 'develop') || contains(github.ref, 'develop') }}" = 'true' ]; then |
Copilot uses AI. Check for mistakes.
minggangw
added a commit
that referenced
this pull request
May 17, 2025
This PR ensures ARM64 build jobs only run on the `develop` branch and extends branch checks to pull request contexts. - Added a `matrix-prep` job that outputs an ARM64 matrix only when targeting `develop`. - Updated the build job to depend on `matrix-prep` and dynamically include ARM64 config. - Enhanced ROS distro detection to consider both `github.ref` and `github.base_ref` for branch-based flags. Fix: #1131
minggangw
added a commit
that referenced
this pull request
May 17, 2025
This PR ensures ARM64 build jobs only run on the `develop` branch and extends branch checks to pull request contexts. - Added a `matrix-prep` job that outputs an ARM64 matrix only when targeting `develop`. - Updated the build job to depend on `matrix-prep` and dynamically include ARM64 config. - Enhanced ROS distro detection to consider both `github.ref` and `github.base_ref` for branch-based flags. Fix: #1131
minggangw
added a commit
that referenced
this pull request
May 17, 2025
This PR ensures ARM64 build jobs only run on the `develop` branch and extends branch checks to pull request contexts. - Added a `matrix-prep` job that outputs an ARM64 matrix only when targeting `develop`. - Updated the build job to depend on `matrix-prep` and dynamically include ARM64 config. - Enhanced ROS distro detection to consider both `github.ref` and `github.base_ref` for branch-based flags. Fix: #1131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures ARM64 build jobs only run on the
developbranch and extends branch checks to pull request contexts.matrix-prepjob that outputs an ARM64 matrix only when targetingdevelop.matrix-prepand dynamically include ARM64 config.github.refandgithub.base_reffor branch-based flags.Fix: #1131