Add support for Kilted #1125
Merged
Add support for Kilted #1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new "Kilted" distro by updating the distro constants, mapping, and associated configurations across tests and CI workflows.
- Updated test expectation in test/test-distro.js from 7 to 8 known distro names.
- Added KILTED in lib/distro.js and updated the DistroNameIdMap accordingly.
- Modified multiple GitHub workflow files to include the new "kilted" branch and appropriate testing steps.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test-distro.js | Updated expected distro count to include the new Kilted distro |
| lib/distro.js | Added a new distro constant for KILTED and updated the DistroNameIdMap |
| .github/workflows/windows-build-and-test.yml | Added "kilted" to branch triggers and updated test commands for Kilted |
| .github/workflows/windows-build-and-test-compatibility.yml | Added Kilted to the compatibility matrix |
| .github/workflows/linux-build-and-test.yml | Included Kilted in branch triggers and enabled testing for Kilted |
| .github/workflows/linux-build-and-test-compatibility.yml | Added Kilted to the compatibility matrix |
| .github/workflows/identify-ros-distro.yml | Introduced KILTED_VAR and implemented logic to identify the Kilted distro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new "Kilted" distro by updating the distro constants, mapping, and associated configurations across tests and CI workflows.
Fix: #1124