Support rcl_get_client_names_and_types_by_node #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/node.js:986
- The doc comment incorrectly refers to 'service names and types'. It should be updated to 'client names and types' to match the function purpose.
* Get service names and types for which a remote node has clients.
|
Coveralls failed, merge this PR into |
minggangw
added a commit
that referenced
this pull request
Apr 8, 2025
This patch implements to expose `rcl_get_client_names_and_types_by_node` provided by `rcl` library, including: 1. Expose `rcl_get_client_names_and_types_by_node` by binding to JavaScript method `GetClientNamesAndTypesByNode`. 2. Add the type definition for `GetClientNamesAndTypesByNode` into `rclnodejs.d.ts`. 3. Add unit test for type into `test/types/index.test-d.ts`. 4. Add example into `example/ros-graph-example.js`. Fix: #1096
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements to expose
rcl_get_client_names_and_types_by_nodeprovided byrcllibrary, including:rcl_get_client_names_and_types_by_nodeby binding to JavaScript methodGetClientNamesAndTypesByNode.GetClientNamesAndTypesByNodeintorclnodejs.d.ts.test/types/index.test-d.ts.example/ros-graph-example.js.Fix: #1096