Skip to content

Generate UUID by crypto #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Generate UUID by crypto #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/action/uuid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
'use strict';

const ActionInterfaces = require('./interfaces.js');
const { v4: uuidv4 } = require('uuid');
const { randomUUID } = require('crypto');

/**
* @class - Represents a unique identifier used by actions.
Expand All @@ -37,7 +37,7 @@ class ActionUuid {
this._bytes = bytes;
} else {
// Generate random UUID.
let uuid = uuidv4().replace(/-/g, '');
let uuid = randomUUID().replace(/-/g, '');
this._bytes = Uint8Array.from(Buffer.from(uuid, 'hex'));
}
}
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
"nan": "^2.22.0",
"prettier": "^3.4.2",
"rimraf": "^6.0.1",
"uuid": "^11.0.3",
"walk": "^2.3.15"
},
"husky": {
Expand Down
1 change: 0 additions & 1 deletion test/test-action-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

const assert = require('assert');
const sinon = require('sinon');
const { v4: uuidv4 } = require('uuid');
const assertUtils = require('./utils.js');
const rclnodejs = require('../index.js');
const { ActionUuid } = require('../index.js');
Expand Down
4 changes: 2 additions & 2 deletions test/test-action-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

const assert = require('assert');
const deepEqual = require('deep-equal');
const { v4: uuidv4 } = require('uuid');
const assertUtils = require('./utils.js');
const { randomUUID } = require('crypto');
const rclnodejs = require('../index.js');

describe('rclnodejs action server', function () {
Expand All @@ -34,7 +34,7 @@ describe('rclnodejs action server', function () {
}

function createUuid() {
let uuid = uuidv4().replace(/-/g, '');
let uuid = randomUUID().replace(/-/g, '');
let bytes = Uint8Array.from(Buffer.from(uuid, 'hex'));

let UUID = rclnodejs.require('unique_identifier_msgs/msg/UUID');
Expand Down
Loading