Better client types producers #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTail
added
enhancement
…ted from inputs of transformation in depictEffect.
…failed to figure out its type.
RobinTail
commented
Jan 1, 2023
| if (outputType && ["number", "string", "boolean"].includes(outputType)) { | ||
| return { type: outputType as "number" | "string" | "boolean" }; | ||
| } else { | ||
| return next({ schema: z.any() }); |
There was a problem hiding this comment.
unknown transformations in output changed from its input type to any
RobinTail
commented
Jan 1, 2023
Comment on lines
-60
to
+71
| const isOptional = propTypeName === "ZodOptional" || value.isOptional(); | ||
| const isOptional = | ||
| isResponse && hasCoercion(value) |
There was a problem hiding this comment.
adjusted optional detections for response with coercion
RobinTail
commented
Jan 1, 2023
| const input = next({ schema: schema.innerType() }); | ||
| const effect = schema._def.effect; | ||
| if (isResponse && effect.type === "transform") { | ||
| const outputType = tryToTransform({ effect, sample: makeSample(input) }); |
There was a problem hiding this comment.
output transformations finally got typed, similar to OpenAPI
RobinTail
commented
Jan 1, 2023
Comment on lines
576
to
-581
| type: string | ||
| format: double | ||
| minimum: 5e-324 | ||
| exclusiveMinimum: false | ||
| maximum: 1.7976931348623157e+308 | ||
| exclusiveMaximum: false |
There was a problem hiding this comment.
no more excessive props inherited during the transformation
|
It looks fine. I just need to write changelog, but I'm too lazy for this today :) |
RobinTail
force-pushed
the
better-zts-producers
branch
from
17ed8e7 to
d242872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to improve zts producers and align them with OpenAPI depicters.