Allow setting of the client interface access modifier based on the model access modifier #4820

pbolduc · 2024-03-17T05:18:35Z

This PR allows changing the client interface access modifier. This PR is to address #1363.

Changes:

When run from the command line, the model type TypeAccessModifier is used. When TypeAccessModifier is set in the OpenApiToCSharpClientCommand, it sets the settings ClientInterfaceAccessModifier to the same value. This is required because TypeAccessModifier is found in the Newtonsoft library and not in CSharpClientGeneratorSettings.
CSharpClientGeneratorSettings defaults ClientInterfaceAccessModifier to public
Updates the C# Client.Interface.liquid to use the new ClientInterfaceAccessModifier setting
Add unit tests to ensure changing the access modifier is correctly changed in the generated C#.

This PR does not address valid combination of setting the generated C# class and model to public, but the interface internal. This would require additional work to expose additional arguments to the command line tool and changes to the UI tools. Someone would need to justify the use case that make this additional combination valid and the effort to implement.

Valid in the table means it is valid C# and will compile. This PR really addresses the last item in the table.

valid	class	model	interface	Handled?
Yes	public	public	public	Yes - worked this way before
Yes	public	public	internal	No - use case?
No	public	internal	public	No - not valid C#
No	public	internal	internal	No - not valid C#
Yes	internal	public	public	Yes - worked this way before
Yes	internal	public	internal	No - edge case?
No	internal	internal	public	No - not valid C#
Yes	internal	internal	internal	Yes - This PR fixes this specific combination

pbolduc · 2024-03-17T05:39:26Z

The failing unit tests pass locally. Is this something that I need to investigate or could it be related to the test runner setup?

Numpsy · 2024-03-17T15:16:39Z

The failing unit tests pass locally. Is this something that I need to investigate or could it be related to the test runner setup?

Looks like the same failure I got in #4785 - I wondered if the test timeout I mentioned at #4785 (comment) simply isn't long enough for the macOS CI runner, though I don't have a Mac to test it locally with so I'm just guessing

jmevel · 2024-03-18T07:23:58Z

Awesome, thanks for your work @pbolduc !

pbolduc · 2024-04-05T18:39:02Z

Are there any issues with this PR? Our team is prevented using the MS Build task to auto generate our C# client because our models are internal. I have to keep reminding my team, they have to manually generate client using the UI and after generating the C# client, they need to edit the generated interface from public to internal.

Please advise if you would like changes by providing feedback on this PR. I have tried to ensure this PR does not introduce any regressions and only makes minimal changes to allow types to be generated as internal to the assembly.

jmevel · 2024-07-29T09:04:35Z

MacOS build failures should be fixed by #4896

#1363 (comment)

Now that #4896 has been merged, @pbolduc could you please re-run the Macos build?
Latest run is from March 17th.

Hoping this PR could be merged soon.

Thanks

pbolduc · 2024-07-29T22:27:26Z

MacOS build failures should be fixed by #4896

#1363 (comment)

Now that #4896 has been merged, @pbolduc could you please re-run the Macos build? Latest run is from March 17th.

Hoping this PR could be merged soon.

Thanks

I am not a maintainer on this Repo. I am not clear on how I would "re-run the Macos build". Usually a maintainer needs to re-run the github actions.

jmevel · 2024-08-02T07:13:19Z

MacOS build failures should be fixed by #4896

#1363 (comment)
Now that #4896 has been merged, @pbolduc could you please re-run the Macos build? Latest run is from March 17th.
Hoping this PR could be merged soon.
Thanks

I am not a maintainer on this Repo. I am not clear on how I would "re-run the Macos build". Usually a maintainer needs to re-run the github actions.

Ok thanks for your answer. I thought maybe the creator of the PR could manually re-run the build without having to push a new commit.

I guess we just have to wait for a maintainer then.

lahma · 2025-06-27T17:13:35Z

Sorry for the wait, thank you for your contribution!

All setting of the client access modifier (RicoSuter#4820)

Updated [NSwag.Core](https://github.com/RicoSuter/NSwag) from 14.4.0 to 14.5.0. <details> <summary>Release notes</summary> _Sourced from [NSwag.Core's releases](https://github.com/RicoSuter/NSwag/releases)._ ## 14.5.0 ## What's Changed * Better support for reading yaml from a stream by @simonthum in RicoSuter/NSwag#5170 * #4821 Cleanup packages to use those provided by framework by @thompson-tomo in RicoSuter/NSwag#4831 * Set GH actions target .NET SDK to 9.0.204 by @lahma in RicoSuter/NSwag#5172 * Better support for reading yaml from a stream (part two) by @simonthum in RicoSuter/NSwag#5171 * Avoid multiple enumeration of array typed path parameters by @Khyalis in RicoSuter/NSwag#5149 * Restores all disabled compiler warnings. 649 and 8765 were missing. by @carlbjorknas in RicoSuter/NSwag#4962 * Fix to explode array parameters implicitly when SchemaType is OpenAPI 3.0 by @Phoosha in RicoSuter/NSwag#5176 * Adding cancellationToken to all calls to ReadAsStringAsync() and ReadAsStreamAsync() by @arshrp in RicoSuter/NSwag#5187 * Remove requirement for specific NET SDK in GH Actions by @lahma in RicoSuter/NSwag#5188 * Adjusted cancellationToken to work for all NSwag supported frameworks by @arshrp in RicoSuter/NSwag#5190 * Allow setting of the client interface access modifier based on the model access modifier by @pbolduc in RicoSuter/NSwag#4820 * Prioritize wildcard over json over first entry for accept content-type by @mdi1984 in RicoSuter/NSwag#5198 * Reduce interface dispatch to improve performance by @lahma in RicoSuter/NSwag#5199 * Surface ExtensionData in CSharpControllerTemplateModel by @hirudan in RicoSuter/NSwag#5204 * Expose the UseRequiredKeyword on CSharpClientGeneratorSettings for CSharp client generator by @r-englund in RicoSuter/NSwag#5205 * Fix to expose an optional param for AbortSignal (for axios) / CancelToken (for fetch) when GenerateClientInterfaces = true by @tomvdk in RicoSuter/NSwag#5202 * Sort client operation responses by status code by @lahma in RicoSuter/NSwag#5206 * TSC UpdateUseDtoClassAndDataConversionCodeProperties cleanup by @lahma in RicoSuter/NSwag#5212 * Update Microsoft.AspNetCore.* references to target 2.3.0 by @lahma in RicoSuter/NSwag#5214 * Convert to using Central Package Management by @lahma in RicoSuter/NSwag#5217 * Convert NSwagStudio setup to use WiX 6 by @lahma in RicoSuter/NSwag#5218 * Add support for TypeScript compilation testing by @lahma in RicoSuter/NSwag#5219 * Replace TypeScript string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5220 * Replace C# string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5221 * Remove deprecated tslint suppression by @CaringDev in RicoSuter/NSwag#5020 * Fix empty enumerable parameter handling in C# client by @lahma in RicoSuter/NSwag#5222 * Fix: C# Code Generation generates method with return default(void) by @nzeemin in RicoSuter/NSwag#4826 * Optimize DefaultParameterNameGenerator and add some more char cleanup by @lahma in RicoSuter/NSwag#5223 * Convert more tests to use verify by @lahma in RicoSuter/NSwag#5224 * Convert to xUnit v3 by @lahma in RicoSuter/NSwag#5225 * Ensure operation names start with alphanumeric character by @lahma in RicoSuter/NSwag#5227 * Change GenerateSampleSpecificationTests to auto verify mode by @lahma in RicoSuter/NSwag#5228 * Show DisplayName for conflicting actions by @Saibamen in RicoSuter/NSwag#5057 * Fix: When generated TS class name is "Error", it is conflicting with TS Error class by @doruk-info in RicoSuter/NSwag#5032 * Update NJsonSchema to 11.4.0, update testsuite to reflect a change in class name generation by @WolfgangHG in RicoSuter/NSwag#5177 * Improve nswag.js parameter handling by @KaterSchnurz in RicoSuter/NSwag#5232 * Use TypeScript 4.3 as default testing version by @lahma in RicoSuter/NSwag#5234 * v14.5.0 by @RicoSuter in RicoSuter/NSwag#5236 ## New Contributors * @simonthum made their first contribution in RicoSuter/NSwag#5170 * @thompson-tomo made their first contribution in RicoSuter/NSwag#4831 * @Khyalis made their first contribution in RicoSuter/NSwag#5149 * @carlbjorknas made their first contribution in RicoSuter/NSwag#4962 * @Phoosha made their first contribution in RicoSuter/NSwag#5176 * @arshrp made their first contribution in RicoSuter/NSwag#5187 * @pbolduc made their first contribution in RicoSuter/NSwag#4820 ... (truncated) Commits viewable in [compare view](RicoSuter/NSwag@v14.4.0...v14.5.0). </details> Updated [NSwag.Core.Yaml](https://github.com/RicoSuter/NSwag) from 14.4.0 to 14.5.0. <details> <summary>Release notes</summary> _Sourced from [NSwag.Core.Yaml's releases](https://github.com/RicoSuter/NSwag/releases)._ ## 14.5.0 ## What's Changed * Better support for reading yaml from a stream by @simonthum in RicoSuter/NSwag#5170 * #4821 Cleanup packages to use those provided by framework by @thompson-tomo in RicoSuter/NSwag#4831 * Set GH actions target .NET SDK to 9.0.204 by @lahma in RicoSuter/NSwag#5172 * Better support for reading yaml from a stream (part two) by @simonthum in RicoSuter/NSwag#5171 * Avoid multiple enumeration of array typed path parameters by @Khyalis in RicoSuter/NSwag#5149 * Restores all disabled compiler warnings. 649 and 8765 were missing. by @carlbjorknas in RicoSuter/NSwag#4962 * Fix to explode array parameters implicitly when SchemaType is OpenAPI 3.0 by @Phoosha in RicoSuter/NSwag#5176 * Adding cancellationToken to all calls to ReadAsStringAsync() and ReadAsStreamAsync() by @arshrp in RicoSuter/NSwag#5187 * Remove requirement for specific NET SDK in GH Actions by @lahma in RicoSuter/NSwag#5188 * Adjusted cancellationToken to work for all NSwag supported frameworks by @arshrp in RicoSuter/NSwag#5190 * Allow setting of the client interface access modifier based on the model access modifier by @pbolduc in RicoSuter/NSwag#4820 * Prioritize wildcard over json over first entry for accept content-type by @mdi1984 in RicoSuter/NSwag#5198 * Reduce interface dispatch to improve performance by @lahma in RicoSuter/NSwag#5199 * Surface ExtensionData in CSharpControllerTemplateModel by @hirudan in RicoSuter/NSwag#5204 * Expose the UseRequiredKeyword on CSharpClientGeneratorSettings for CSharp client generator by @r-englund in RicoSuter/NSwag#5205 * Fix to expose an optional param for AbortSignal (for axios) / CancelToken (for fetch) when GenerateClientInterfaces = true by @tomvdk in RicoSuter/NSwag#5202 * Sort client operation responses by status code by @lahma in RicoSuter/NSwag#5206 * TSC UpdateUseDtoClassAndDataConversionCodeProperties cleanup by @lahma in RicoSuter/NSwag#5212 * Update Microsoft.AspNetCore.* references to target 2.3.0 by @lahma in RicoSuter/NSwag#5214 * Convert to using Central Package Management by @lahma in RicoSuter/NSwag#5217 * Convert NSwagStudio setup to use WiX 6 by @lahma in RicoSuter/NSwag#5218 * Add support for TypeScript compilation testing by @lahma in RicoSuter/NSwag#5219 * Replace TypeScript string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5220 * Replace C# string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5221 * Remove deprecated tslint suppression by @CaringDev in RicoSuter/NSwag#5020 * Fix empty enumerable parameter handling in C# client by @lahma in RicoSuter/NSwag#5222 * Fix: C# Code Generation generates method with return default(void) by @nzeemin in RicoSuter/NSwag#4826 * Optimize DefaultParameterNameGenerator and add some more char cleanup by @lahma in RicoSuter/NSwag#5223 * Convert more tests to use verify by @lahma in RicoSuter/NSwag#5224 * Convert to xUnit v3 by @lahma in RicoSuter/NSwag#5225 * Ensure operation names start with alphanumeric character by @lahma in RicoSuter/NSwag#5227 * Change GenerateSampleSpecificationTests to auto verify mode by @lahma in RicoSuter/NSwag#5228 * Show DisplayName for conflicting actions by @Saibamen in RicoSuter/NSwag#5057 * Fix: When generated TS class name is "Error", it is conflicting with TS Error class by @doruk-info in RicoSuter/NSwag#5032 * Update NJsonSchema to 11.4.0, update testsuite to reflect a change in class name generation by @WolfgangHG in RicoSuter/NSwag#5177 * Improve nswag.js parameter handling by @KaterSchnurz in RicoSuter/NSwag#5232 * Use TypeScript 4.3 as default testing version by @lahma in RicoSuter/NSwag#5234 * v14.5.0 by @RicoSuter in RicoSuter/NSwag#5236 ## New Contributors * @simonthum made their first contribution in RicoSuter/NSwag#5170 * @thompson-tomo made their first contribution in RicoSuter/NSwag#4831 * @Khyalis made their first contribution in RicoSuter/NSwag#5149 * @carlbjorknas made their first contribution in RicoSuter/NSwag#4962 * @Phoosha made their first contribution in RicoSuter/NSwag#5176 * @arshrp made their first contribution in RicoSuter/NSwag#5187 * @pbolduc made their first contribution in RicoSuter/NSwag#4820 ... (truncated) Commits viewable in [compare view](RicoSuter/NSwag@v14.4.0...v14.5.0). </details> Updated [NSwag.Generation.AspNetCore](https://github.com/RicoSuter/NSwag) from 14.4.0 to 14.5.0. <details> <summary>Release notes</summary> _Sourced from [NSwag.Generation.AspNetCore's releases](https://github.com/RicoSuter/NSwag/releases)._ ## 14.5.0 ## What's Changed * Better support for reading yaml from a stream by @simonthum in RicoSuter/NSwag#5170 * #4821 Cleanup packages to use those provided by framework by @thompson-tomo in RicoSuter/NSwag#4831 * Set GH actions target .NET SDK to 9.0.204 by @lahma in RicoSuter/NSwag#5172 * Better support for reading yaml from a stream (part two) by @simonthum in RicoSuter/NSwag#5171 * Avoid multiple enumeration of array typed path parameters by @Khyalis in RicoSuter/NSwag#5149 * Restores all disabled compiler warnings. 649 and 8765 were missing. by @carlbjorknas in RicoSuter/NSwag#4962 * Fix to explode array parameters implicitly when SchemaType is OpenAPI 3.0 by @Phoosha in RicoSuter/NSwag#5176 * Adding cancellationToken to all calls to ReadAsStringAsync() and ReadAsStreamAsync() by @arshrp in RicoSuter/NSwag#5187 * Remove requirement for specific NET SDK in GH Actions by @lahma in RicoSuter/NSwag#5188 * Adjusted cancellationToken to work for all NSwag supported frameworks by @arshrp in RicoSuter/NSwag#5190 * Allow setting of the client interface access modifier based on the model access modifier by @pbolduc in RicoSuter/NSwag#4820 * Prioritize wildcard over json over first entry for accept content-type by @mdi1984 in RicoSuter/NSwag#5198 * Reduce interface dispatch to improve performance by @lahma in RicoSuter/NSwag#5199 * Surface ExtensionData in CSharpControllerTemplateModel by @hirudan in RicoSuter/NSwag#5204 * Expose the UseRequiredKeyword on CSharpClientGeneratorSettings for CSharp client generator by @r-englund in RicoSuter/NSwag#5205 * Fix to expose an optional param for AbortSignal (for axios) / CancelToken (for fetch) when GenerateClientInterfaces = true by @tomvdk in RicoSuter/NSwag#5202 * Sort client operation responses by status code by @lahma in RicoSuter/NSwag#5206 * TSC UpdateUseDtoClassAndDataConversionCodeProperties cleanup by @lahma in RicoSuter/NSwag#5212 * Update Microsoft.AspNetCore.* references to target 2.3.0 by @lahma in RicoSuter/NSwag#5214 * Convert to using Central Package Management by @lahma in RicoSuter/NSwag#5217 * Convert NSwagStudio setup to use WiX 6 by @lahma in RicoSuter/NSwag#5218 * Add support for TypeScript compilation testing by @lahma in RicoSuter/NSwag#5219 * Replace TypeScript string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5220 * Replace C# string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5221 * Remove deprecated tslint suppression by @CaringDev in RicoSuter/NSwag#5020 * Fix empty enumerable parameter handling in C# client by @lahma in RicoSuter/NSwag#5222 * Fix: C# Code Generation generates method with return default(void) by @nzeemin in RicoSuter/NSwag#4826 * Optimize DefaultParameterNameGenerator and add some more char cleanup by @lahma in RicoSuter/NSwag#5223 * Convert more tests to use verify by @lahma in RicoSuter/NSwag#5224 * Convert to xUnit v3 by @lahma in RicoSuter/NSwag#5225 * Ensure operation names start with alphanumeric character by @lahma in RicoSuter/NSwag#5227 * Change GenerateSampleSpecificationTests to auto verify mode by @lahma in RicoSuter/NSwag#5228 * Show DisplayName for conflicting actions by @Saibamen in RicoSuter/NSwag#5057 * Fix: When generated TS class name is "Error", it is conflicting with TS Error class by @doruk-info in RicoSuter/NSwag#5032 * Update NJsonSchema to 11.4.0, update testsuite to reflect a change in class name generation by @WolfgangHG in RicoSuter/NSwag#5177 * Improve nswag.js parameter handling by @KaterSchnurz in RicoSuter/NSwag#5232 * Use TypeScript 4.3 as default testing version by @lahma in RicoSuter/NSwag#5234 * v14.5.0 by @RicoSuter in RicoSuter/NSwag#5236 ## New Contributors * @simonthum made their first contribution in RicoSuter/NSwag#5170 * @thompson-tomo made their first contribution in RicoSuter/NSwag#4831 * @Khyalis made their first contribution in RicoSuter/NSwag#5149 * @carlbjorknas made their first contribution in RicoSuter/NSwag#4962 * @Phoosha made their first contribution in RicoSuter/NSwag#5176 * @arshrp made their first contribution in RicoSuter/NSwag#5187 * @pbolduc made their first contribution in RicoSuter/NSwag#4820 ... (truncated) Commits viewable in [compare view](RicoSuter/NSwag@v14.4.0...v14.5.0). </details> Updated [NSwag.MSBuild](https://github.com/RicoSuter/NSwag) from 14.4.0 to 14.5.0. <details> <summary>Release notes</summary> _Sourced from [NSwag.MSBuild's releases](https://github.com/RicoSuter/NSwag/releases)._ ## 14.5.0 ## What's Changed * Better support for reading yaml from a stream by @simonthum in RicoSuter/NSwag#5170 * #4821 Cleanup packages to use those provided by framework by @thompson-tomo in RicoSuter/NSwag#4831 * Set GH actions target .NET SDK to 9.0.204 by @lahma in RicoSuter/NSwag#5172 * Better support for reading yaml from a stream (part two) by @simonthum in RicoSuter/NSwag#5171 * Avoid multiple enumeration of array typed path parameters by @Khyalis in RicoSuter/NSwag#5149 * Restores all disabled compiler warnings. 649 and 8765 were missing. by @carlbjorknas in RicoSuter/NSwag#4962 * Fix to explode array parameters implicitly when SchemaType is OpenAPI 3.0 by @Phoosha in RicoSuter/NSwag#5176 * Adding cancellationToken to all calls to ReadAsStringAsync() and ReadAsStreamAsync() by @arshrp in RicoSuter/NSwag#5187 * Remove requirement for specific NET SDK in GH Actions by @lahma in RicoSuter/NSwag#5188 * Adjusted cancellationToken to work for all NSwag supported frameworks by @arshrp in RicoSuter/NSwag#5190 * Allow setting of the client interface access modifier based on the model access modifier by @pbolduc in RicoSuter/NSwag#4820 * Prioritize wildcard over json over first entry for accept content-type by @mdi1984 in RicoSuter/NSwag#5198 * Reduce interface dispatch to improve performance by @lahma in RicoSuter/NSwag#5199 * Surface ExtensionData in CSharpControllerTemplateModel by @hirudan in RicoSuter/NSwag#5204 * Expose the UseRequiredKeyword on CSharpClientGeneratorSettings for CSharp client generator by @r-englund in RicoSuter/NSwag#5205 * Fix to expose an optional param for AbortSignal (for axios) / CancelToken (for fetch) when GenerateClientInterfaces = true by @tomvdk in RicoSuter/NSwag#5202 * Sort client operation responses by status code by @lahma in RicoSuter/NSwag#5206 * TSC UpdateUseDtoClassAndDataConversionCodeProperties cleanup by @lahma in RicoSuter/NSwag#5212 * Update Microsoft.AspNetCore.* references to target 2.3.0 by @lahma in RicoSuter/NSwag#5214 * Convert to using Central Package Management by @lahma in RicoSuter/NSwag#5217 * Convert NSwagStudio setup to use WiX 6 by @lahma in RicoSuter/NSwag#5218 * Add support for TypeScript compilation testing by @lahma in RicoSuter/NSwag#5219 * Replace TypeScript string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5220 * Replace C# string contain asserts with Verify tests by @lahma in RicoSuter/NSwag#5221 * Remove deprecated tslint suppression by @CaringDev in RicoSuter/NSwag#5020 * Fix empty enumerable parameter handling in C# client by @lahma in RicoSuter/NSwag#5222 * Fix: C# Code Generation generates method with return default(void) by @nzeemin in RicoSuter/NSwag#4826 * Optimize DefaultParameterNameGenerator and add some more char cleanup by @lahma in RicoSuter/NSwag#5223 * Convert more tests to use verify by @lahma in RicoSuter/NSwag#5224 * Convert to xUnit v3 by @lahma in RicoSuter/NSwag#5225 * Ensure operation names start with alphanumeric character by @lahma in RicoSuter/NSwag#5227 * Change GenerateSampleSpecificationTests to auto verify mode by @lahma in RicoSuter/NSwag#5228 * Show DisplayName for conflicting actions by @Saibamen in RicoSuter/NSwag#5057 * Fix: When generated TS class name is "Error", it is conflicting with TS Error class by @doruk-info in RicoSuter/NSwag#5032 * Update NJsonSchema to 11.4.0, update testsuite to reflect a change in class name generation by @WolfgangHG in RicoSuter/NSwag#5177 * Improve nswag.js parameter handling by @KaterSchnurz in RicoSuter/NSwag#5232 * Use TypeScript 4.3 as default testing version by @lahma in RicoSuter/NSwag#5234 * v14.5.0 by @RicoSuter in RicoSuter/NSwag#5236 ## New Contributors * @simonthum made their first contribution in RicoSuter/NSwag#5170 * @thompson-tomo made their first contribution in RicoSuter/NSwag#4831 * @Khyalis made their first contribution in RicoSuter/NSwag#5149 * @carlbjorknas made their first contribution in RicoSuter/NSwag#4962 * @Phoosha made their first contribution in RicoSuter/NSwag#5176 * @arshrp made their first contribution in RicoSuter/NSwag#5187 * @pbolduc made their first contribution in RicoSuter/NSwag#4820 ... (truncated) Commits viewable in [compare view](RicoSuter/NSwag@v14.4.0...v14.5.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

pbolduc changed the title ~~All setting of the client access modifier.~~ Allow setting of the client interface access modifier based on the model access modifier Mar 17, 2024

pbolduc mentioned this pull request Mar 20, 2024

Oracle data api project bcgov/jag-traffic-courts-online#1690

Merged

12 tasks

jmevel mentioned this pull request Jun 12, 2024

Generated c# interface for Client with internal modifier on DTO classes should be internal too #1363

Closed

lahma approved these changes Aug 2, 2024

View reviewed changes

All setting of the client access modifier.

d4b4ac6

lahma force-pushed the feature/interface-access-modifier branch from 5cf8149 to d4b4ac6 Compare June 27, 2025 16:56

lahma merged commit 4b4a35d into RicoSuter:master Jun 27, 2025
3 checks passed

lahma mentioned this pull request Jun 27, 2025

Make the access modifier for the client interface match the client #5195

Closed

Doomic added a commit to Doomic/NSwag that referenced this pull request Jun 30, 2025

Merge pull request #1 from RicoSuter/master

8557383

All setting of the client access modifier (RicoSuter#4820)

This was referenced Aug 5, 2025

Bump Microsoft.AspNetCore.Mvc.Testing and 6 others Zac-Digital/Service-Directory#49

Open

Bump NSwag.CodeGeneration.CSharp from 14.4.0 to 14.5.0 christianhelle/curlgenerator#189

Closed

This was referenced Aug 7, 2025

Bump NSwag.Core.Yaml from 14.4.0 to 14.5.0 christianhelle/curlgenerator#190

Closed

chore: Bump NSwag.Annotations from 14.4.0 to 14.5.0 Teck-Lab/Teck.Shop#74

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Allow setting of the client interface access modifier based on the model access modifier #4820

Allow setting of the client interface access modifier based on the model access modifier #4820

Uh oh!

pbolduc commented Mar 17, 2024 •

edited

Loading

Uh oh!

pbolduc commented Mar 17, 2024

Uh oh!

Numpsy commented Mar 17, 2024 •

edited

Loading

Uh oh!

jmevel commented Mar 18, 2024

Uh oh!

pbolduc commented Apr 5, 2024

Uh oh!

jmevel commented Jul 29, 2024

Uh oh!

pbolduc commented Jul 29, 2024

Uh oh!

jmevel commented Aug 2, 2024

Uh oh!

Uh oh!

lahma commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Allow setting of the client interface access modifier based on the model access modifier #4820

Allow setting of the client interface access modifier based on the model access modifier #4820

Uh oh!

Conversation

pbolduc commented Mar 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pbolduc commented Mar 17, 2024

Uh oh!

Numpsy commented Mar 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmevel commented Mar 18, 2024

Uh oh!

pbolduc commented Apr 5, 2024

Uh oh!

jmevel commented Jul 29, 2024

Uh oh!

pbolduc commented Jul 29, 2024

Uh oh!

jmevel commented Aug 2, 2024

Uh oh!

Uh oh!

lahma commented Jun 27, 2025

Uh oh!

Uh oh!

pbolduc commented Mar 17, 2024 •

edited

Loading

Numpsy commented Mar 17, 2024 •

edited

Loading