Skip to content

Suggestion for restructoring readPump() and adressing some connection issues with it #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Mar 9, 2019
Merged

Suggestion for restructoring readPump() and adressing some connection issues with it #114

merged 27 commits into from
Mar 9, 2019

Conversation

SchulteMK
Copy link
Collaborator

No description provided.

@SchulteMK
Implement explicit Connect and Disconnect [WIP]
865c267 
goroutines now will be terminated on disconnect
@SchulteMK
Redo closeHandler for wsConn
dd0662f
@SchulteMK
Completely removes the writePump
212903c
@SchulteMK
Seperates Read and Write functions into their own files
9c17efe
@SchulteMK
Todos
b764849
@SchulteMK
Makes read and write more symmetrical
a08ee14
@SchulteMK
extract some logic out of readPump
6c61df7
@SchulteMK
Unexport Connect again, because it's not need from outside
fbe2974
@SchulteMK
Add Restore() to reconnect back to whatsapp after failed connection
4fa016b 
go-whatsapp should not auto-reconnect, it should be called by user
@SchulteMK
extract wsConn, wsClose & Mutex into own struct
6248226
@SchulteMK
fix minor login bug
5e881a0
@SchulteMK
Make sure only one Login or Restore is happening at the same time
8e71e13
@SchulteMK
Merge branch 'master' into feature/pumprewrite
13f7ae1
@SchulteMK
go.mod for dev
52bc8c7
@SchulteMK
read.go
7fe9987
@SchulteMK
Use errors package to wrap errors
3f3bee7
@SchulteMK
Merge branch 'feature/pumprewrite'
823b895
@SchulteMK
Merge latest master into feature branch
405d10a
@SchulteMK
fix merge artifact
164c5eb
@SchulteMK
Merge remote-tracking branch 'origin/master'
048499a
@SchulteMK
Merge remote-tracking branch 'Rhymen/master'
9a0919f
@SchulteMK
fix hash
e077344
@SchulteMK
fix another merge artifact
85b0521
@SchulteMK
return error type on conn failure -> ability to check err and reconnect
c600eda
@SchulteMK
lower keepAlive time as suggested in many issues
39b63f1
@SchulteMK
Run disconnecting procedure if connection is closed by server
8b90bdd
@SchulteMK
change ErrConnectionFailed to not shadow real error
e591678
@SchulteMK SchulteMK mentioned this pull request Mar 7, 2019
Closed
@SchulteMK
Copy link
Collaborator Author

Addresses #106 #111 #120

@SchulteMK SchulteMK merged commit 3f56542 into Rhymen:master Mar 9, 2019
@SchulteMK SchulteMK mentioned this pull request Mar 9, 2019
Closed
@KrzysztofMadejski KrzysztofMadejski mentioned this pull request Mar 12, 2019
Closed
@SchulteMK SchulteMK mentioned this pull request Mar 13, 2019
Closed
This was referenced Mar 14, 2019
Closed
Closed
@SchulteMK SchulteMK mentioned this pull request Mar 20, 2019
Closed
@SchulteMK SchulteMK mentioned this pull request Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchulteMK @KrzysztofMadejski