Skip to content

Conversation

dligr
Copy link
Member

@dligr dligr commented Aug 12, 2025

Brief Description of What This PR Does

  • Makes currents' noise textures 2D instead of 3D for less repetition.
  • Current shifting is now done by moving two noise textures and multiplying them with eachother
  • Somewhat improves noise textures to make them more interesting (like currents going on for longer and having some whirlpool-like areas)
  • Enables trails (for surface patches mostly), also colors some currents

Related Issues

--

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

dligr added 13 commits August 8, 2025 18:32
Now there're two textures that are moved and combined based on time passing, so there's no need for a 3rd dimension
Moreso, the new main noise texture is made in a special way to make currents go on forever (theoretically)
TODO: only enable them for certain patches (and configure colors probably, per patch as well)
This one is more random that the previous one and, importantly, has no single direction in which it goes
Two noises were combined while making it, selectively increasing flow in some areas to avoid making dead-ends
Which would make them more unique, probably
@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

@Patryk26g
Copy link
Contributor

I checked the look of it and I think it looks really nice, but when I go faster with my cell to new areas, the currents are not present there and only appear after a second o two. is it possible for them to cover a bigger area so that they are visible wherever player goes?

@dligr
Copy link
Member Author

dligr commented Aug 13, 2025

So, I increased the extents of the particle spawn area by 1.5 and I think that this fixes the problem. Unfortunately, increasing the box extents also requires increasing particle count, so if the issue persists in some way, the solution might be to move the box slightly in front of the player to let particles spawn in advance.

@dligr dligr requested review from a team August 13, 2025 16:05
@dligr dligr added the review label Aug 13, 2025
@dligr dligr marked this pull request as ready for review August 14, 2025 13:20
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good now. I tested in game and I think the trails are probably a good improvement but I don't recall anyone saying anything about the trail visuals yet. Patches with no visual changes also seemed good to me.

@hhyyrylainen hhyyrylainen merged commit a23efac into master Aug 21, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Thrive Planning Aug 21, 2025
@hhyyrylainen hhyyrylainen deleted the currents_overhaul branch August 21, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants