Skip to content

Add a sprinting tutorial before the engulfing tutorial #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

0HyperCube
Copy link
Contributor

@0HyperCube 0HyperCube commented May 4, 2025

Brief Description of What This PR Does

Include a new sprint tutorial just before the engulf tutorial. This should help new players as it is difficult to complete the engulf tutorial without sprinting.
sprint tutorial

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen
Copy link
Member

Tutorials may not have scrollbars on them. You need to increase the size of the tutorial until there is no scrollbar.

The engulfing tutorial is already pretty long which is why it doesn't mention any hunting tips. I've been thinking that we might want to have a sprinting tutorial in general as we need to explain that sprinting uses significantly more energy than not sprinting. So a tutorial that just says to use shift to get speed, might do more harm than good as players who sprint all the time and then die due to running out of resources is not an improvement to the game in my opinion.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.3 milestone May 5, 2025
@0HyperCube
Copy link
Contributor Author

I have created a new tutorial. However I'm not too sure about the show and hide conditions. Currently it is shown when there is a microbe chunk that the player might want but before the engulfing tutorial. It is hidden when the sprint is enabled and then disabled.
sprint tutorial

@hhyyrylainen hhyyrylainen changed the title Add mention of sprinting to the engulf tutorial Add a sprinting tutorial before the engulfing tutorial May 6, 2025
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks close to perfect now, I'd like to see just a few tiny tweaks to the code. Also you need to run the localization update script so that other locale files are updated: https://github.com/Revolutionary-Games/Thrive/blob/master/doc/working_with_translations.md#updating-the-localizations

@0HyperCube 0HyperCube force-pushed the sprint-tutorial branch 2 times, most recently from 3b11a53 to 4effa83 Compare May 6, 2025 16:14
@0HyperCube
Copy link
Contributor Author

Thanks, I've done that.

@hhyyrylainen
Copy link
Member

That should be fine, though your code is not correctly indented (the jetbrains check is failing due to multiple lines with incorrect indent levels). If you are going to fix those today please note that the "build" jobs will all fail due to this issue on the server: aws/aws-sdk-net#3797

@revolutionary-bot
Copy link

The lead programmer for Thrive is currently on vacation until 2025-07-07. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed.

PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged.

@0HyperCube 0HyperCube marked this pull request as draft June 8, 2025 20:12
@hhyyrylainen
Copy link
Member

Is this ready for another look or is this still waiting for some more changes (as this is marked as a draft)?

@hhyyrylainen hhyyrylainen removed this from the Release 0.8.3 milestone Aug 8, 2025
@github-project-automation github-project-automation bot moved this to In progress in Thrive Planning Aug 8, 2025
@hhyyrylainen hhyyrylainen moved this from In progress to started but stuck (help wanted) in Thrive Planning Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: started but stuck (help wanted)
Development

Successfully merging this pull request may close these issues.

3 participants