-
-
Notifications
You must be signed in to change notification settings - Fork 558
Change Miche and Close Button Arrangement #5989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Miche and Close Button Arrangement #5989
Conversation
This now has merge conflicts as I merged some other PRs. One problem with the button arrangement that the location of the close button is platform dependent. I assume you didn't implement that yet. To avoid having to put the close on the left/right depending on the platform (there's code in the game to detect that for the custom confirmation dialogs if I remember right) the miches button could be placed above the close button with some space between them. |
Sorry, could you elaborate on the location of the close button being platform dependent? I'm not sure I follow |
The position of the cancel button in a popup depends on whether you are using Windows or Linux. Here's our code where that is handled:
So if you want to keep the close and miches button on the same line, they should follow the platform dependent convention of which one of them is on the right side. |
I was not aware of that, thank you very much for letting me know. |
As part of a tutorial overhaul, I'll increase the height of the prediction popup slightly. This will close the related issue, but if you want you can continue working on this PR. |
We are currently in feature freeze until the next release. |
This PR has been inactive for a while and as such is being marked If this is still being worked on / will probably resume work at |
This PR is being automatically closed due to being stale. Please |
Brief Description of What This PR Does
Moves the miche button to be fixed horizontally with the close button, instead of scrolling with the text.
Related Issues
Resolves #5915
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.