Skip to content

Conversation

PollastreGH
Copy link
Contributor

Brief Description of What This PR Does

Moves the miche button to be fixed horizontally with the close button, instead of scrolling with the text. auto_evo_prediction_menu

Related Issues

Resolves #5915

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen
Copy link
Member

This now has merge conflicts as I merged some other PRs.

One problem with the button arrangement that the location of the close button is platform dependent. I assume you didn't implement that yet. To avoid having to put the close on the left/right depending on the platform (there's code in the game to detect that for the custom confirmation dialogs if I remember right) the miches button could be placed above the close button with some space between them.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.2 milestone Mar 7, 2025
@PollastreGH
Copy link
Contributor Author

Sorry, could you elaborate on the location of the close button being platform dependent? I'm not sure I follow

@hhyyrylainen
Copy link
Member

The position of the cancel button in a popup depends on whether you are using Windows or Linux. Here's our code where that is handled:

if (DisplayServer.GetSwapCancelOk() && !Engine.IsEditorHint())

So if you want to keep the close and miches button on the same line, they should follow the platform dependent convention of which one of them is on the right side.

@PollastreGH
Copy link
Contributor Author

I was not aware of that, thank you very much for letting me know.

@hhyyrylainen
Copy link
Member

As part of a tutorial overhaul, I'll increase the height of the prediction popup slightly. This will close the related issue, but if you want you can continue working on this PR.

@hhyyrylainen hhyyrylainen removed this from the Release 0.8.2 milestone Apr 30, 2025
@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

Copy link

This PR has been inactive for a while and as such is being marked
stale. This PR will be automatically closed if this stays stale
for a while.

If this is still being worked on / will probably resume work at
some point please feel free to continue working on this and reopen
this in case this was already automatically closed.

@github-actions github-actions bot added the stale label Jul 30, 2025
Copy link

This PR is being automatically closed due to being stale. Please
only reopen this if work is actually resuming on this PR. We have
automatic PR closing to make sure that PRs that never get finished
aren't forever hanging out in the list of open PRs.

@github-actions github-actions bot closed this Aug 30, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Thrive Planning Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Default height of auto-evo prediction popup should be slightly increased
3 participants