Skip to content

Set CMAKE_POSITION_INDEPENDENT_CODE if need be #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
langou merged 1 commit into from
Mar 18, 2022
Merged

Set CMAKE_POSITION_INDEPENDENT_CODE if need be #61

langou merged 1 commit into from
Mar 18, 2022

Conversation

@prj-
Copy link
Contributor

@prj- prj- commented Mar 17, 2022

Fixes #58.

@prj-
Copy link
Contributor Author

prj- commented Mar 17, 2022

I see no harm in always calling set_property(TARGET xintface PROPERTY POSITION_INDEPENDENT_CODE TRUE) since this target is not used in the library afterwards, if I'm not mistaken.

@prj-
Copy link
Contributor Author

prj- commented Mar 17, 2022 •
edited
Loading

Could you please restart the Makefile CI workflow? This job does not modify any of the Makefiles (which is rather concerning, IMHO...).

weslleyspereira
weslleyspereira approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@weslleyspereira weslleyspereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prj-. I agree with you. The change seems harmless. Since it solves your linking problem, I think it is a good way to go.

@prj-
Copy link
Contributor Author

prj- commented Mar 17, 2022

Great. We are testing this branch across all PETSc workers right now, it looks promising https://gitlab.com/petsc/petsc/-/pipelines/495056038 (some failures are to be expected, e.g., forgot to turn off --download-scalapack for jobs without Fortran...).

@prj-
Copy link
Contributor Author

prj- commented Mar 18, 2022

Could you please merge if you are OK with these changes?

@langou langou merged commit 5bad748 into Reference-ScaLAPACK:master Mar 18, 2022
@weslleyspereira weslleyspereira mentioned this pull request Jul 20, 2022
Merged
@branchv branchv mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weslleyspereira weslleyspereira weslleyspereira approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CMakeFiles/xintface.dir/Cintface.c.o: relocation R_X86_64_32S against symbol `stdout@@GLIBC_2.2.5' can not be used when making a PIE object

3 participants

@prj- @weslleyspereira @langou