Fix Mingw compilation #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi @Baljak. Would you be interested in reviewing #56? In particular: #56 (comment)? Thanks. |
weslleyspereira
approved these changes
Mar 8, 2022
Collaborator
weslleyspereira
left a comment
weslleyspereira
left a comment
There was a problem hiding this comment.
Looks good to me!!
Collaborator
|
Hi @Baljak. Could you please force an empty commit so that your changes are subjected to the new tests? Thanks! |
Contributor
Author
|
I have rebased my branch on master so the tests should now run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issues when compiling with Mingw:
if (UNIX)statements withif (NOT MSVC)as GCC (and LLVM) behavior on Windows is the same as on Unix/Linux.scalapack_build.cmakeas it is not used anymore.