set project version and shared library soname #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the ScaLAPACK project version in a single place, at the project command in CMakeLists.txt. This defines SCALAPACK_VERSION, from which cmake derives SCALAPACK_VERSION_MAJOR, SCALAPACK_VERSION_MINOR, SCALAPACK_VERSION_PATCH Use SCALAPACK_VERSION as the shared library VERSION (defining the shared library file as libscalapack.so.2.2.1) and use SCALAPACK_VERSION_MAJOR.SCALAPACK_VERSION_MINOR as the shared library SOVERSION (defining the soname as libscalapack.so.2.2) That is, assume that the ABI updates with each MINOR release and reflect that in the soname. An API update (and therefore an ABI update) would be expected with any MAJOR release. No ABI update should occur with a PATCH release. Closes: Reference-ScaLAPACK#46
Contributor
Author
|
I took the liberty here of setting the patch version to 1. i.e. SCALAPACK_VERSION 2.2.1. I also took the liberty of defining the soname for the windows build (dll shared libraries). What's good for unix should still be good for windows. |
Collaborator
|
Thanks @drew-parsons! It looks really good. Can you please consider including on the README file something like the following? |
Contributor
Author
Done. |
Collaborator
|
Great job! Thanks! |
weslleyspereira
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the ScaLAPACK project version in a single place, at the project
command in CMakeLists.txt.
This defines SCALAPACK_VERSION, from which cmake derives
SCALAPACK_VERSION_MAJOR, SCALAPACK_VERSION_MINOR, SCALAPACK_VERSION_PATCH
Use SCALAPACK_VERSION as the shared library VERSION (defining the
shared library file as libscalapack.so.2.2.1)
and use SCALAPACK_VERSION_MAJOR.SCALAPACK_VERSION_MINOR as the shared
library SOVERSION (defining the soname as libscalapack.so.2.2)
That is, assume that the ABI updates with each MINOR release and
reflect that in the soname.
An API update (and therefore an ABI update) would be expected with any
MAJOR release.
No ABI update should occur with a PATCH release.
Closes: #46