Use pointer macro to prevent integer oveflow #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An integer overflow occurs and causes segmentation fault when 2D row/col index is linearized using 32-bit integers. PBLAS Mptr() macro should be used instead. This fix only fixes address calculations with row, column, and leading dimension. There might be other places where an overflow occurs but they may not matter for practical purposes because they would require very large matrices or very long vectors within a single process.
Contributor
|
Thanks @luszczek ! |
pradeeptrgit
pushed a commit
to amd/aocl-scalapack
that referenced
this pull request
Nov 24, 2025
Use pointer macro to prevent integer oveflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An integer overflow occurs and causes segmentation fault
when 2D row/col index is linearized using 32-bit integers.
PBLAS Mptr() macro should be used instead.
This fix only fixes address calculations with row, column, and leading
dimension. There might be other places where an overflow occurs but
they may not matter for practical purposes because they would require
very large matrices or very long vectors within a single process.