Skip to content

remove duplicates #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

remove duplicates #46

merged 2 commits into from
Aug 14, 2025

Conversation

osoukup
Copy link
Collaborator

@osoukup osoukup commented Aug 14, 2025

I found two issues which were generating duplicate trees in the results.

  1. extend_with_product_mappings was sometimes introducing duplicates
  2. re-parenting might result into having duplicate branches again

Closes PSDEVOPS-4469

@osoukup osoukup requested a review from jasinner August 14, 2025 15:14
@osoukup osoukup self-assigned this Aug 14, 2025
@jasinner
Copy link
Collaborator

This is a nice improvement, thank you. I created a follow up issue to clean up the output even more:

PSDEVOPS-4471

@jasinner jasinner merged commit 25e5590 into main Aug 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasinner jasinner Awaiting requested review from jasinner

Assignees

@osoukup osoukup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osoukup @jasinner