- 
                Notifications
    You must be signed in to change notification settings 
- Fork 81
NOTIF-512 Notify org admins when a webhook is disabled #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa369fa    to
    4b21c83      
    Compare
  
    | Codecov ReportBase: 60.29% // Head: 60.47% // Increases project coverage by  
 Additional details and impacted files@@             Coverage Diff              @@
##             master    #1482      +/-   ##
============================================
+ Coverage     60.29%   60.47%   +0.17%     
- Complexity     1083     1088       +5     
============================================
  Files           222      224       +2     
  Lines          5322     5369      +47     
  Branches        520      523       +3     
============================================
+ Hits           3209     3247      +38     
- Misses         1928     1937       +9     
  Partials        185      185              
 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. | 
c413414    to
    cc30ea2      
    Compare
  
    cc30ea2    to
    f68b9e6      
    Compare
  
    f68b9e6    to
    430f16a      
    Compare
  
    430f16a    to
    6bfd089      
    Compare
  
    6bfd089    to
    63ce973      
    Compare
  
    | Rebased to fix conflicts. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| Recipient recipients = new Recipient.RecipientBuilder() | ||
| .withOnlyAdmins(true) | ||
| .withIgnoreUserPreferences(true) | ||
| .build(); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be removed in the future, once we have something to have defaults (e.g. all admins subscribed for these notifications and a default behavior group on the account that can be removed) so they can fine-tune this setting (maybe a particular RBAC group would be the one handling these errors and no the admin itself.
| .withIgnoreUserPreferences(true) | ||
| .build(); | ||
|  | ||
| Action action = new Action.ActionBuilder() | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a side note, the suggested builder syntax has been merged, but not deployed yet!
When a webhook is automatically disabled because of 4xx or 5xx failures, an action is emitted on the
platform.notifications.ingresstopic with the following information:consolenotificationsintegration-disabledThe action also contains additional information about the issue:
Using a default behavior group, the event type described above will be used to send an email notification to the org admins of the account that owns the disabled integration. The email body will vary depending on the type of the error.